From: Andi Kleen <ak@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Kan Liang <kan.liang@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Andi Kleen <andi@firstfloor.org>,
Michael Petlan <mpetlan@redhat.com>
Subject: Re: [RFC] perf tools: Wrong filter_band* values in json calculation"
Date: Tue, 9 Oct 2018 14:18:39 -0700 [thread overview]
Message-ID: <20181009211839.GK32651@tassilo.jf.intel.com> (raw)
In-Reply-To: <20181009100144.GG6499@krava>
On Tue, Oct 09, 2018 at 12:01:44PM +0200, Jiri Olsa wrote:
> On Wed, Oct 03, 2018 at 07:45:50AM -0700, Andi Kleen wrote:
> > > note there's couple of changes that actually changed
> > > the number completely, like:
> > >
> > > - "Filter": "edge=1,filter_band2=4000",
> > > + "Filter": "edge=1,filter_band2=30",
> >
> > Thanks. Looks good. I'll fix the scripts to generate the uncore events.
>
> hi,
> any idea when you could post an update for this?
Can just use your patch for the existing event lists. You can add
Acked-by: Andi Kleen <ak@linux.intel.com>
I was mainly worried about future updates, but it doesn't seem to be a problem.
-Andi
next prev parent reply other threads:[~2018-10-09 21:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 7:20 [PATCH] Revert "perf tools: Fix PMU term format max value calculation" Jiri Olsa
2018-10-03 14:34 ` [RFC] perf tools: Wrong filter_band* values in json calculation" Jiri Olsa
2018-10-03 14:45 ` Andi Kleen
2018-10-09 10:01 ` Jiri Olsa
2018-10-09 21:18 ` Andi Kleen [this message]
2018-10-10 8:03 ` [PATCH] perf tools: Fix wrong filter_band* values for uncore events Jiri Olsa
2018-10-10 12:58 ` Arnaldo Carvalho de Melo
2018-10-18 6:17 ` [tip:perf/urgent] perf vendor events intel: " tip-bot for Jiri Olsa
2018-10-09 9:59 ` [PATCH] Revert "perf tools: Fix PMU term format max value calculation" Jiri Olsa
2018-10-09 13:52 ` Arnaldo Carvalho de Melo
2018-10-18 6:17 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009211839.GK32651@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).