From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CA4C43441 for ; Wed, 10 Oct 2018 06:12:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABF252087D for ; Wed, 10 Oct 2018 06:12:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABF252087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726871AbeJJNd3 (ORCPT ); Wed, 10 Oct 2018 09:33:29 -0400 Received: from mga17.intel.com ([192.55.52.151]:27030 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbeJJNd3 (ORCPT ); Wed, 10 Oct 2018 09:33:29 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 23:12:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,363,1534834800"; d="scan'208";a="87153673" Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 09 Oct 2018 23:12:54 -0700 Received: from tiger-server (dazhang1-ssd.sh.intel.com [10.239.48.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 1189758014B; Tue, 9 Oct 2018 23:12:51 -0700 (PDT) Date: Wed, 10 Oct 2018 20:52:12 +0800 From: Yi Zhang To: Dan Williams Cc: alexander.h.duyck@linux.intel.com, Pasha Tatashin , Michal Hocko , linux-nvdimm , Dave Hansen , Linux Kernel Mailing List , Linux MM , =?utf-8?B?SsOpcsO0bWU=?= Glisse , rppt@linux.vnet.ibm.com, Andrew Morton , Ingo Molnar , "Kirill A. Shutemov" Subject: Re: [PATCH v5 4/4] mm: Defer ZONE_DEVICE page initialization to the point where we init pgmap Message-ID: <20181010125211.GA45572@tiger-server> Mail-Followup-To: Dan Williams , alexander.h.duyck@linux.intel.com, Pasha Tatashin , Michal Hocko , linux-nvdimm , Dave Hansen , Linux Kernel Mailing List , Linux MM , =?utf-8?B?SsOpcsO0bWU=?= Glisse , rppt@linux.vnet.ibm.com, Andrew Morton , Ingo Molnar , "Kirill A. Shutemov" References: <20180925200551.3576.18755.stgit@localhost.localdomain> <20180925202053.3576.66039.stgit@localhost.localdomain> <20181009170051.GA40606@tiger-server> <25092df0-b7b4-d456-8409-9c004cb6e422@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-10-09 at 14:19:32 -0700, Dan Williams wrote: > On Tue, Oct 9, 2018 at 1:34 PM Alexander Duyck > wrote: > > > > On 10/9/2018 11:04 AM, Dan Williams wrote: > > > On Tue, Oct 9, 2018 at 3:21 AM Yi Zhang wrote: > [..] > > > That comment is incorrect, device-pages are never onlined. So I think > > > we can just skip that call to __SetPageReserved() unless the memory > > > range is MEMORY_DEVICE_{PRIVATE,PUBLIC}. > > > > > > > When pages are "onlined" via __free_pages_boot_core they clear the > > reserved bit, that is the reason for the comment. The reserved bit is > > meant to indicate that the page cannot be swapped out or moved based on > > the description of the bit. > > ...but ZONE_DEVICE pages are never onlined so I would expect > memmap_init_zone_device() to know that detail. > > > I would think with that being the case we still probably need the call > > to __SetPageReserved to set the bit with the expectation that it will > > not be cleared for device-pages since the pages are not onlined. > > Removing the call to __SetPageReserved would probably introduce a number > > of regressions as there are multiple spots that use the reserved bit to > > determine if a page can be swapped out to disk, mapped as system memory, > > or migrated. Another things, it seems page_init/set_reserved already been done in the move_pfn_range_to_zone |-->memmap_init_zone |-->for_each_page_in_pfn |-->__init_single_page |-->SetPageReserved Why we haven't remove these redundant initial in memmap_init_zone? Correct me if I missed something. > > Right, this is what Yi is working on... the PageReserved flag is > problematic for KVM. Auditing those locations it seems as long as we > teach hibernation to avoid ZONE_DEVICE ranges we can safely not set > the reserved flag for DAX pages. What I'm trying to avoid is a local > KVM hack to check for DAX pages when the Reserved flag is not > otherwise needed. Thanks Dan. Provide the patch link. https://lore.kernel.org/lkml/cover.1536342881.git.yi.z.zhang@linux.intel.com > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm