From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mtd@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH 3/3] eeprom: at25: Split writes in two SPI transfers to optimize DMA
Date: Wed, 10 Oct 2018 15:40:36 +0200 [thread overview]
Message-ID: <20181010134036.8296-4-geert+renesas@glider.be> (raw)
In-Reply-To: <20181010134036.8296-1-geert+renesas@glider.be>
Currently EEPROM writes are implemented using a single SPI transfer,
which contains all of command, address, and payload data bytes.
As some SPI controllers impose limitations on transfers with respect to
the use of DMA, they may have to fall back to PIO. E.g. DMA may require
the transfer length to be a multiple of 4 bytes.
Optimize writes for DMA by splitting writes in two SPI transfers:
- The first transfer contains command and address bytes,
- The second transfer contains the actual payload data, now stored at
the start of the (kmalloc() aligned) buffer, to improve payload
alignment.
E.g. for a 25LC040 EEPROM with a page size 16 bytes, a 16-byte write
aligned to the page size was transferred using an 18-byte write.
After this change, the write is split in a 2-byte and an aligned 16-byte
write.
Note that EEPROM reads already use a similar scheme, due to the
different data directions for command and address bytes versus payload
data.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/misc/eeprom/at25.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
index 5c8dc7ad391435f7..f84d1681835b4ded 100644
--- a/drivers/misc/eeprom/at25.c
+++ b/drivers/misc/eeprom/at25.c
@@ -136,6 +136,7 @@ static int at25_ee_write(void *priv, unsigned int off, void *val, size_t count)
int status = 0;
unsigned buf_size;
u8 *bounce;
+ struct spi_transfer t[2];
if (unlikely(off >= at25->chip.byte_len))
return -EFBIG;
@@ -160,7 +161,7 @@ static int at25_ee_write(void *priv, unsigned int off, void *val, size_t count)
unsigned long timeout, retries;
unsigned segment;
unsigned offset = off;
- u8 *cp = bounce;
+ u8 *cp = bounce + buf_size;
int sr;
u8 instr;
@@ -194,9 +195,17 @@ static int at25_ee_write(void *priv, unsigned int off, void *val, size_t count)
segment = buf_size - (offset % buf_size);
if (segment > count)
segment = count;
- memcpy(cp, buf, segment);
- status = spi_write(at25->spi, bounce,
- segment + at25->addrlen + 1);
+ memcpy(bounce, buf, segment);
+
+ memset(t, 0, sizeof(t));
+
+ t[0].tx_buf = bounce + buf_size;
+ t[0].len = at25->addrlen + 1;
+
+ t[1].tx_buf = bounce;
+ t[1].len = segment;
+
+ status = spi_sync_transfer(at25->spi, t, ARRAY_SIZE(t));
dev_dbg(&at25->spi->dev, "write %u bytes at %u --> %d\n",
segment, offset, status);
if (status < 0)
--
2.17.1
next prev parent reply other threads:[~2018-10-10 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 13:40 [PATCH 0/3] eeprom: at25: SPI transfer improvements Geert Uytterhoeven
2018-10-10 13:40 ` [PATCH 1/3] eeprom: at25: Drop obsolete cast in at25_ee_write() Geert Uytterhoeven
2018-10-10 13:40 ` [PATCH 2/3] eeprom: at25: Use spi_message_init_with_transfers() instead of open coding Geert Uytterhoeven
2018-10-10 13:40 ` Geert Uytterhoeven [this message]
2018-10-10 21:47 ` [PATCH 3/3] eeprom: at25: Split writes in two SPI transfers to optimize DMA Trent Piepho
2018-10-11 6:59 ` Geert Uytterhoeven
2018-10-10 13:43 ` [PATCH 0/3] eeprom: at25: SPI transfer improvements Geert Uytterhoeven
2018-10-10 13:43 ` [PATCH 1/3] eeprom: at25: Drop obsolete cast in at25_ee_write() Geert Uytterhoeven
2018-10-10 14:01 ` Arnd Bergmann
2018-10-10 14:42 ` Geert Uytterhoeven
2018-10-10 13:43 ` [PATCH 2/3] eeprom: at25: Use spi_message_init_with_transfers() instead of open coding Geert Uytterhoeven
2018-10-10 14:02 ` Arnd Bergmann
2018-10-10 13:43 ` [PATCH 3/3] eeprom: at25: Split writes in two SPI transfers to optimize DMA Geert Uytterhoeven
2018-10-10 14:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010134036.8296-4-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).