From: Khazhismel Kumykov <khazhy@google.com>
To: hirofumi@mail.parknet.co.jp
Cc: linux-kernel@vger.kernel.org, Khazhismel Kumykov <khazhy@google.com>
Subject: [PATCH] fs/fat: add cond_resched to fat_count_free_clusters
Date: Wed, 10 Oct 2018 10:26:23 -0700 [thread overview]
Message-ID: <20181010172623.57033-1-khazhy@google.com> (raw)
On non-preempt kernels this loop can take a long time (more than 50
ticks) processing through entries.
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
---
fs/fat/fatent.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
index defc2168de91..f58c0cacc531 100644
--- a/fs/fat/fatent.c
+++ b/fs/fat/fatent.c
@@ -682,6 +682,7 @@ int fat_count_free_clusters(struct super_block *sb)
if (ops->ent_get(&fatent) == FAT_ENT_FREE)
free++;
} while (fat_ent_next(sbi, &fatent));
+ cond_resched();
}
sbi->free_clusters = free;
sbi->free_clus_valid = 1;
--
2.19.0.605.g01d371f741-goog
next reply other threads:[~2018-10-10 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 17:26 Khazhismel Kumykov [this message]
2018-10-11 18:50 ` [PATCH] fs/fat: add cond_resched to fat_count_free_clusters OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010172623.57033-1-khazhy@google.com \
--to=khazhy@google.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).