* [PATCH] fs/fat: add cond_resched to fat_count_free_clusters
@ 2018-10-10 17:26 Khazhismel Kumykov
2018-10-11 18:50 ` OGAWA Hirofumi
0 siblings, 1 reply; 2+ messages in thread
From: Khazhismel Kumykov @ 2018-10-10 17:26 UTC (permalink / raw)
To: hirofumi; +Cc: linux-kernel, Khazhismel Kumykov
On non-preempt kernels this loop can take a long time (more than 50
ticks) processing through entries.
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
---
fs/fat/fatent.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
index defc2168de91..f58c0cacc531 100644
--- a/fs/fat/fatent.c
+++ b/fs/fat/fatent.c
@@ -682,6 +682,7 @@ int fat_count_free_clusters(struct super_block *sb)
if (ops->ent_get(&fatent) == FAT_ENT_FREE)
free++;
} while (fat_ent_next(sbi, &fatent));
+ cond_resched();
}
sbi->free_clusters = free;
sbi->free_clus_valid = 1;
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/fat: add cond_resched to fat_count_free_clusters
2018-10-10 17:26 [PATCH] fs/fat: add cond_resched to fat_count_free_clusters Khazhismel Kumykov
@ 2018-10-11 18:50 ` OGAWA Hirofumi
0 siblings, 0 replies; 2+ messages in thread
From: OGAWA Hirofumi @ 2018-10-11 18:50 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Khazhismel Kumykov
Khazhismel Kumykov <khazhy@google.com> writes:
> On non-preempt kernels this loop can take a long time (more than 50
> ticks) processing through entries.
>
> Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
> ---
> fs/fat/fatent.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
> index defc2168de91..f58c0cacc531 100644
> --- a/fs/fat/fatent.c
> +++ b/fs/fat/fatent.c
> @@ -682,6 +682,7 @@ int fat_count_free_clusters(struct super_block *sb)
> if (ops->ent_get(&fatent) == FAT_ENT_FREE)
> free++;
> } while (fat_ent_next(sbi, &fatent));
> + cond_resched();
> }
> sbi->free_clusters = free;
> sbi->free_clus_valid = 1;
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks, looks good.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 17:26 [PATCH] fs/fat: add cond_resched to fat_count_free_clusters Khazhismel Kumykov
2018-10-11 18:50 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).