From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
Stephen Bates <sbates@raithlin.com>,
Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>, Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH 1/5] mm/sparse: add common helper to mark all memblocks present
Date: Thu, 11 Oct 2018 15:30:09 +0200 [thread overview]
Message-ID: <20181011133009.GA7276@lst.de> (raw)
In-Reply-To: <20181005161642.2462-2-logang@deltatee.com>
> + for_each_memblock(memory, reg) {
> + int nid = memblock_get_region_node(reg);
> +
> + memory_present(nid, memblock_region_memory_base_pfn(reg),
> + memblock_region_memory_end_pfn(reg));
Any reason you have a local variable for the node id while you happily
get away without one for the others? Why not simply:
for_each_memblock(memory, reg) {
memory_present(memblock_get_region_node(reg)
memblock_region_memory_base_pfn(reg),
memblock_region_memory_end_pfn(reg));
}
next prev parent reply other threads:[~2018-10-11 13:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 16:16 [PATCH 0/5] sparsemem support for RISC-V Logan Gunthorpe
2018-10-05 16:16 ` [PATCH 1/5] mm/sparse: add common helper to mark all memblocks present Logan Gunthorpe
2018-10-11 13:30 ` Christoph Hellwig [this message]
2018-10-05 16:16 ` [PATCH 2/5] ARM: mm: make use of new memblocks_present() helper Logan Gunthorpe
2018-10-05 16:16 ` [PATCH 3/5] arm64: " Logan Gunthorpe
2018-10-05 16:32 ` Catalin Marinas
2018-10-05 16:16 ` [PATCH 4/5] sh: " Logan Gunthorpe
2018-10-05 16:16 ` [PATCH 5/5] RISC-V: Implement sparsemem Logan Gunthorpe
2018-10-11 0:27 ` Palmer Dabbelt
2018-10-11 12:18 ` Stephen Bates
2018-10-15 17:39 ` Palmer Dabbelt
2018-10-11 13:37 ` Christoph Hellwig
2018-10-11 16:24 ` Logan Gunthorpe
2018-10-11 17:30 ` Logan Gunthorpe
2018-10-11 18:45 ` Logan Gunthorpe
2018-10-11 20:21 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011133009.GA7276@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=palmer@sifive.com \
--cc=pasha.tatashin@oracle.com \
--cc=sbates@raithlin.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).