From: Tiwei Bie <tiwei.bie@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
virtio-dev@lists.oasis-open.org, wexu@redhat.com,
jfreimann@redhat.com, maxime.coquelin@redhat.com,
zhihong.wang@intel.com
Subject: Re: [virtio-dev] Re: [PATCH net-next v2 0/5] virtio: support packed ring
Date: Thu, 11 Oct 2018 22:34:43 +0800 [thread overview]
Message-ID: <20181011143443.GA18183@debian> (raw)
In-Reply-To: <20181011101656-mutt-send-email-mst@kernel.org>
On Thu, Oct 11, 2018 at 10:17:15AM -0400, Michael S. Tsirkin wrote:
> On Thu, Oct 11, 2018 at 10:13:31PM +0800, Tiwei Bie wrote:
> > On Thu, Oct 11, 2018 at 09:48:48AM -0400, Michael S. Tsirkin wrote:
> > > On Thu, Oct 11, 2018 at 08:12:21PM +0800, Tiwei Bie wrote:
> > > > > > But if it's not too late, I second for a OUT_OF_ORDER feature.
> > > > > > Starting from in order can have much simpler code in driver.
> > > > > >
> > > > > > Thanks
> > > > >
> > > > > It's tricky to change the flag polarity because of compatibility
> > > > > with legacy interfaces. Why is this such a big deal?
> > > > >
> > > > > Let's teach drivers about IN_ORDER, then if devices
> > > > > are in order it will get enabled by default.
> > > >
> > > > Yeah, make sense.
> > > >
> > > > Besides, I have done some further profiling and debugging
> > > > both in kernel driver and DPDK vhost. Previously I was mislead
> > > > by a bug in vhost code. I will send a patch to fix that bug.
> > > > With that bug fixed, the performance of packed ring in the
> > > > test between kernel driver and DPDK vhost is better now.
> > >
> > > OK, if we get a performance gain on the virtio side, we can finally
> > > upstream it. If you see that please re-post ASAP so we can
> > > put it in the next kernel release.
> >
> > Got it, I will re-post ASAP.
> >
> > Thanks!
>
>
> Pls remember to include data on performance gain in the cover letter.
Sure. I'll try to include some performance analyses.
next prev parent reply other threads:[~2018-10-11 14:39 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 2:27 [PATCH net-next v2 0/5] virtio: support packed ring Tiwei Bie
2018-07-11 2:27 ` [PATCH net-next v2 1/5] virtio: add packed ring definitions Tiwei Bie
2018-09-07 13:51 ` Michael S. Tsirkin
2018-09-10 2:13 ` Tiwei Bie
2018-09-12 12:53 ` Michael S. Tsirkin
2018-07-11 2:27 ` [PATCH net-next v2 2/5] virtio_ring: support creating packed ring Tiwei Bie
2018-09-07 14:03 ` Michael S. Tsirkin
2018-09-10 2:28 ` Tiwei Bie
2018-09-12 7:51 ` Tiwei Bie
2018-09-12 16:12 ` Michael S. Tsirkin
2018-09-12 12:45 ` Michael S. Tsirkin
2018-07-11 2:27 ` [PATCH net-next v2 3/5] virtio_ring: add packed ring support Tiwei Bie
2018-09-07 13:49 ` Michael S. Tsirkin
2018-09-10 2:03 ` Tiwei Bie
2018-09-12 16:22 ` Michael S. Tsirkin
2018-11-07 17:48 ` Michael S. Tsirkin
2018-11-08 1:38 ` Tiwei Bie
2018-11-08 8:18 ` Jason Wang
2018-11-08 11:51 ` Tiwei Bie
2018-11-08 15:56 ` Michael S. Tsirkin
2018-11-09 1:50 ` Tiwei Bie
2018-11-09 2:30 ` Jason Wang
2018-11-09 4:00 ` Michael S. Tsirkin
2018-11-09 10:05 ` Jason Wang
2018-11-08 14:14 ` Michael S. Tsirkin
2018-11-09 2:25 ` Jason Wang
2018-11-09 3:58 ` Michael S. Tsirkin
2018-11-09 10:04 ` Jason Wang
2018-07-11 2:27 ` [PATCH net-next v2 4/5] virtio_ring: add event idx support in packed ring Tiwei Bie
2018-09-07 14:10 ` Michael S. Tsirkin
2018-09-10 2:35 ` [virtio-dev] " Tiwei Bie
2018-07-11 2:27 ` [PATCH net-next v2 5/5] virtio_ring: enable " Tiwei Bie
2018-07-11 2:52 ` [PATCH net-next v2 0/5] virtio: support " Jason Wang
2018-07-12 21:44 ` David Miller
2018-07-13 0:52 ` Jason Wang
2018-07-13 3:26 ` Michael S. Tsirkin
2018-08-27 14:00 ` Michael S. Tsirkin
2018-08-28 5:51 ` [virtio-dev] " Jens Freimann
2018-09-07 1:22 ` Tiwei Bie
2018-09-07 13:00 ` Michael S. Tsirkin
2018-09-10 3:00 ` Tiwei Bie
2018-09-10 3:33 ` Jason Wang
2018-09-11 5:37 ` Tiwei Bie
2018-09-12 16:16 ` Michael S. Tsirkin
2018-09-13 8:59 ` Tiwei Bie
2018-09-13 9:47 ` Jason Wang
2018-10-10 14:36 ` Michael S. Tsirkin
2018-10-11 12:12 ` Tiwei Bie
2018-10-11 13:48 ` Michael S. Tsirkin
2018-10-11 14:13 ` Tiwei Bie
2018-10-11 14:17 ` Michael S. Tsirkin
2018-10-11 14:34 ` Tiwei Bie [this message]
2018-09-12 13:06 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011143443.GA18183@debian \
--to=tiwei.bie@intel.com \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wexu@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).