linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eugene Syromiatnikov <esyr@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Firoz Khan <firoz.khan@linaro.org>,
	linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	gregkh <gregkh@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	y2038 Mailman List <y2038@lists.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arch <linux-arch@vger.kernel.org>,
	Deepa Dinamani <deepa.kernel@gmail.com>,
	Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v3 7/7] ia64: wire up system calls
Date: Thu, 11 Oct 2018 17:06:58 +0200	[thread overview]
Message-ID: <20181011150654.GB22118@asgard.redhat.com> (raw)
In-Reply-To: <CAK8P3a3OS-aKFrb5g1i00-+G1+uZqEkH0C1FX08tTx=-89-hfQ@mail.gmail.com>

On Thu, Oct 11, 2018 at 09:24:43AM +0200, Arnd Bergmann wrote:
> On Thu, Oct 11, 2018 at 6:26 AM Firoz Khan <firoz.khan@linaro.org> wrote:
> > +# perf_event_open requires an architecture specific implementation
> > +326    common  perf_event_open                 sys_perf_event_open
[...]
> 
> I don't think that's correct for these two. perf_event_open() of
> course requires 'perf' support that ia64 does not have

That's actuallt quite funny, given the fact that IA-64 has perfmonctl()
which likely was the precursor of current perf infractructure.

> > +# pkey_mprotect requires an architecture specific implementation
> > +328    common  pkey_mprotect                   sys_pkey_mprotect
> > +# pkey_alloc requires an architecture specific implementation
> > +329    common  pkey_alloc                      sys_pkey_alloc
> > +# pkey_free requires an architecture specific implementation
> > +330    common  pkey_free                       sys_pkey_free
> 
> One comment for all pkey calls would be sufficient. More importantly
> it requires hardware support that ia64 does not have AFAICT.

Except it has[1].

[1] https://www.thailand.intel.com/content/dam/www/public/us/en/documents/manuals/itanium-architecture-software-developer-rev-2-3-vol-2-manual.pdf#page=78

  parent reply	other threads:[~2018-10-11 15:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  4:24 [PATCH v3 0/7] ia64: system call table generation support Firoz Khan
2018-10-11  4:24 ` [PATCH v3 1/7] ia64: add __NR_old_getpagesize in uapi/asm/unistd.h Firoz Khan
2018-10-11  4:24 ` [PATCH v3 2/7] ia64: replace NR_syscalls macro from asm/unistd.h Firoz Khan
2018-10-11  4:24 ` [PATCH v3 3/7] ia64: add an offset for system call number Firoz Khan
2018-10-11  4:24 ` [PATCH v3 4/7] ia64: replace the system call table entries from entry.S Firoz Khan
2018-10-11  7:32   ` Arnd Bergmann
2018-10-11  8:35     ` Firoz Khan
2018-10-11  4:24 ` [PATCH v3 5/7] ia64: add system call table generation support Firoz Khan
2018-10-11  4:24 ` [PATCH v3 6/7] ia64: uapi header and system call table file generation Firoz Khan
2018-10-11  4:24 ` [PATCH v3 7/7] ia64: wire up system calls Firoz Khan
2018-10-11  7:24   ` Arnd Bergmann
2018-10-11  8:35     ` Firoz Khan
2018-10-11 15:06     ` Eugene Syromiatnikov [this message]
2018-10-11 15:09       ` Arnd Bergmann
2018-10-11 17:28 ` [PATCH v3 0/7] ia64: system call table generation support Luck, Tony
2018-10-12  4:01   ` Firoz Khan
2018-10-12 16:11     ` Luck, Tony
2018-10-12 19:40       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011150654.GB22118@asgard.redhat.com \
    --to=esyr@redhat.com \
    --cc=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=fenghua.yu@intel.com \
    --cc=firoz.khan@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).