From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Petr Mladek <pmladek@suse.com>, "Tobin C . Harding" <me@tobin.cc>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] lib/vsprintf: Hash remaining raw addresses
Date: Thu, 11 Oct 2018 20:01:48 +0300 [thread overview]
Message-ID: <20181011170148.GM15943@smile.fi.intel.com> (raw)
In-Reply-To: <20181011084249.4520-1-geert+renesas@glider.be>
On Thu, Oct 11, 2018 at 10:42:46AM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> There are still two format specifiers that print unhanced kernel
> addresses, potentially leaking sensitive information regarding the
> kernel layout in memory.
>
> This patch series fixes this by printing hashed addresses instead.
Looks nice!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Changes compared to v1:
> - Get rid of the forward declaration for ptr_to_id(),
> - Add Reviewed-by.
>
> Thanks!
>
> Geert Uytterhoeven (3):
> lib/vsprintf: Prepare for more general use of ptr_to_id()
> lib/vsprintf: Hash legacy clock addresses
> lib/vsprintf: Hash printed address for netdev bits fallback
>
> Documentation/core-api/printk-formats.rst | 5 +-
> lib/vsprintf.c | 216 +++++++++++-----------
> 2 files changed, 110 insertions(+), 111 deletions(-)
>
> --
> 2.17.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-10-11 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 8:42 [PATCH v2 0/3] lib/vsprintf: Hash remaining raw addresses Geert Uytterhoeven
2018-10-11 8:42 ` [PATCH v2 1/3] lib/vsprintf: Prepare for more general use of ptr_to_id() Geert Uytterhoeven
2018-10-12 10:39 ` Petr Mladek
2018-10-12 11:25 ` Geert Uytterhoeven
2018-10-11 8:42 ` [PATCH v2 2/3] lib/vsprintf: Hash legacy clock addresses Geert Uytterhoeven
2018-10-12 10:39 ` Petr Mladek
2018-10-11 8:42 ` [PATCH v2 3/3] lib/vsprintf: Hash printed address for netdev bits fallback Geert Uytterhoeven
2018-10-12 10:40 ` Petr Mladek
2018-10-11 17:01 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011170148.GM15943@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).