From: Greg KH <gregkh@linuxfoundation.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, linux-afs@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] afs: Fix cell proc list
Date: Fri, 12 Oct 2018 13:31:34 +0200 [thread overview]
Message-ID: <20181012113134.GA22324@kroah.com> (raw)
In-Reply-To: <153929434917.24725.5423867421481211888.stgit@warthog.procyon.org.uk>
On Thu, Oct 11, 2018 at 10:45:49PM +0100, David Howells wrote:
> Access to the list of cells by /proc/net/afs/cells has a couple of
> problems:
>
> (1) It should be checking against SEQ_START_TOKEN for the keying the
> header line.
>
> (2) It's only holding the RCU read lock, so it can't just walk over the
> list without following the proper RCU methods.
>
> Fix these by using an hlist instead of an ordinary list and using the
> appropriate accessor functions to follow it with RCU.
>
> Since the code that adds a cell to the list must also necessarily change,
> sort the list on insertion whilst we're at it.
>
> Fixes: 989782dcdc91 ("afs: Overhaul cell database management")
> Signed-off-by: David Howells <dhowells@redhat.com>
Now applied, thanks.
greg k-h
prev parent reply other threads:[~2018-10-12 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 21:45 [PATCH] afs: Fix cell proc list David Howells
2018-10-12 11:31 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012113134.GA22324@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).