archive mirror
 help / color / mirror / Atom feed
From: Thierry Reding <>
To: Brian Masney <>
Subject: Re: [PATCH v2 0/3] treewide: add vibrator support for various MSM SOCs
Date: Fri, 12 Oct 2018 13:47:49 +0200	[thread overview]
Message-ID: <20181012114749.GC31561@ulmo> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On Wed, Sep 26, 2018 at 07:51:09PM -0400, Brian Masney wrote:
> This patch set adds support for the vibrator found on various Qualcomm
> MSM SOCs. This is based on work from:
> Jonathan Marek from qcom,pwm-vibrator.c in the PostmarketOS repo:
> Jongrak Kwon and Devin Kim from msm_pwm_vibrator.c in the downstream
> Android 3.4.0 sources:
> Driver was tested on a LG Nexus 5 (hammerhead) phone using rumble-test:

Looking at all of this it seems like this would be more appropriately
implemented as a force-feedback input device directly. The only reason
you seem to be making this a PWM driver is so that it can be used in
conjunction with pwm-vibrator. The device itself doesn't seem to be a
generic PWM in the way that the PWM framework expects it.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-10-12 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 23:51 Brian Masney
2018-09-26 23:51 ` [PATCH v2 1/3] dt-bindings: pwm: msm-vibrator: new bindings for MSM vibrator PWM Brian Masney
2018-09-26 23:51 ` [PATCH v2 2/3] pwm: msm-vibrator: new driver for the vibrator found on various MSM SOCs Brian Masney
2018-09-26 23:51 ` [PATCH v2 3/3] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator Brian Masney
2018-10-12 11:47 ` Thierry Reding [this message]
2018-10-16  0:52 ` [PATCH v2 0/3] treewide: add vibrator support for various MSM SOCs Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012114749.GC31561@ulmo \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 0/3] treewide: add vibrator support for various MSM SOCs' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).