From: Wolfram Sang <wsa@the-dreams.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
linux-renesas-soc@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] mmc: tmio: remove confusing TMIO_MMC_HAVE_HIGH_REG flag
Date: Mon, 15 Oct 2018 00:30:12 +0200 [thread overview]
Message-ID: <20181014223011.GD3260@kunai> (raw)
In-Reply-To: <1539143492-32605-1-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Wed, Oct 10, 2018 at 12:51:30PM +0900, Masahiro Yamada wrote:
> CTL_SDIO_REGS is a register specific to tmio_mmc.c
>
> Currently, we handle it in tmio_mmc_core.c, hence need
> TMIO_MMC_HAVE_HIGH_REG flag to prevent the other platforms
> from accessing to it.
>
> We can just move CTL_SDIO_REGS to tmio_mmc.c
> and delete the confusing TMIO_MMC_HAVE_HIGH_REG flag.
Looks good, thanks! Ulf, please give me Monday to test the changes on
some more devices...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-14 22:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 3:51 [PATCH v3 0/2] mmc: tmio: remove confusing TMIO_MMC_HAVE_HIGH_REG flag Masahiro Yamada
2018-10-10 3:51 ` [PATCH v3 1/2] mmc: tmio: move MFD variant reset to a platform hook Masahiro Yamada
2018-10-14 22:27 ` Wolfram Sang
2018-10-15 11:32 ` Wolfram Sang
2018-10-10 3:51 ` [PATCH v3 2/2] mmc: tmio: remove TMIO_MMC_HAVE_HIGH_REG flag Masahiro Yamada
2018-10-14 22:28 ` Wolfram Sang
2018-10-15 11:32 ` Wolfram Sang
2018-10-14 22:30 ` Wolfram Sang [this message]
2018-10-15 13:15 ` [PATCH v3 0/2] mmc: tmio: remove confusing " Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181014223011.GD3260@kunai \
--to=wsa@the-dreams.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).