linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: uniphier-sd: fix DMA disabling
Date: Mon, 15 Oct 2018 00:33:29 +0200	[thread overview]
Message-ID: <20181014223329.GF3260@kunai> (raw)
In-Reply-To: <1539356258-12374-2-git-send-email-yamada.masahiro@socionext.com>

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

On Fri, Oct 12, 2018 at 11:57:37PM +0900, Masahiro Yamada wrote:
> Once DMA is enabled, it is not possible to disable it because
> uniphier_sd_dma_endisable() always sets the DMA_ENABLE_DMASDRW bit
> regardless of the argument 'enable'. It should disable DMA when
> 'enable' is false.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-10-14 22:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 14:57 [PATCH 0/2] mmc: uniphier-sd: two bug-fixes Masahiro Yamada
2018-10-12 14:57 ` [PATCH 1/2] mmc: uniphier-sd: fix DMA disabling Masahiro Yamada
2018-10-14 22:33   ` Wolfram Sang [this message]
2018-10-15 13:15   ` Ulf Hansson
2018-10-12 14:57 ` [PATCH 2/2] mmc: uniphier-sd: avoid using broken DMA RX channel Masahiro Yamada
2018-10-14 22:35   ` Wolfram Sang
2018-10-15 13:15   ` Ulf Hansson
2018-10-14 22:33 ` [PATCH 0/2] mmc: uniphier-sd: two bug-fixes Wolfram Sang
2018-10-15  3:12   ` Masahiro Yamada
2018-10-15  7:33     ` Wolfram Sang
2018-10-15 12:51       ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181014223329.GF3260@kunai \
    --to=wsa@the-dreams.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).