linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] doc: rcu: Fix code listing in performance and scalability requirements
@ 2018-10-15  2:29 Joel Fernandes (Google)
  2018-10-15 17:36 ` Paul E. McKenney
  0 siblings, 1 reply; 2+ messages in thread
From: Joel Fernandes (Google) @ 2018-10-15  2:29 UTC (permalink / raw)
  To: linux-kernel; +Cc: Joel Fernandes (Google), Paul E. McKenney

The code listing under this section has a quick quiz that says line 19
uses rcu_access_pointer, but the code listing itself does not. Fix this.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
 .../RCU/Design/Requirements/Requirements.html    |  2 +-
 kernel/sys.c                                     | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/Documentation/RCU/Design/Requirements/Requirements.html b/Documentation/RCU/Design/Requirements/Requirements.html
index 4fae55056c1d..f74a2233865c 100644
--- a/Documentation/RCU/Design/Requirements/Requirements.html
+++ b/Documentation/RCU/Design/Requirements/Requirements.html
@@ -1596,7 +1596,7 @@ used in place of <tt>synchronize_rcu()</tt> as follows:
 16   struct foo *p;
 17
 18   spin_lock(&amp;gp_lock);
-19   p = rcu_dereference(gp);
+19   p = rcu_access_pointer(gp);
 20   if (!p) {
 21     spin_unlock(&amp;gp_lock);
 22     return false;
-- 
2.19.0.605.g01d371f741-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] doc: rcu: Fix code listing in performance and scalability requirements
  2018-10-15  2:29 [PATCH] doc: rcu: Fix code listing in performance and scalability requirements Joel Fernandes (Google)
@ 2018-10-15 17:36 ` Paul E. McKenney
  0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2018-10-15 17:36 UTC (permalink / raw)
  To: Joel Fernandes (Google); +Cc: linux-kernel

On Sun, Oct 14, 2018 at 07:29:42PM -0700, Joel Fernandes (Google) wrote:
> The code listing under this section has a quick quiz that says line 19
> uses rcu_access_pointer, but the code listing itself does not. Fix this.
> 
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Good eyes!  Queued for the merge window after this coming one,
thank you!

							Thanx, Paul

> ---
>  .../RCU/Design/Requirements/Requirements.html    |  2 +-
>  kernel/sys.c                                     | 16 ++++++++++++++++
>  2 files changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/RCU/Design/Requirements/Requirements.html b/Documentation/RCU/Design/Requirements/Requirements.html
> index 4fae55056c1d..f74a2233865c 100644
> --- a/Documentation/RCU/Design/Requirements/Requirements.html
> +++ b/Documentation/RCU/Design/Requirements/Requirements.html
> @@ -1596,7 +1596,7 @@ used in place of <tt>synchronize_rcu()</tt> as follows:
>  16   struct foo *p;
>  17
>  18   spin_lock(&amp;gp_lock);
> -19   p = rcu_dereference(gp);
> +19   p = rcu_access_pointer(gp);
>  20   if (!p) {
>  21     spin_unlock(&amp;gp_lock);
>  22     return false;
> -- 
> 2.19.0.605.g01d371f741-goog
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-15 17:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-15  2:29 [PATCH] doc: rcu: Fix code listing in performance and scalability requirements Joel Fernandes (Google)
2018-10-15 17:36 ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).