linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guo Ren <ren_guo@c-sky.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
	robh+dt@kernel.org, mark.rutland@arm.com, will.deacon@arm.com,
	jhogan@kernel.org, paul.burton@mips.com, peterz@infradead.org,
	arnd@arndb.de, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH V12 0/8] C-SKY(csky) Linux Kernel Driver
Date: Mon, 15 Oct 2018 10:32:34 +0800	[thread overview]
Message-ID: <20181015023234.GA24121@guoren-Inspiron-7460> (raw)
In-Reply-To: <36e2cb6d-6d9e-4764-a6dd-a5f74cab5a09@linaro.org>

Hi Daniel,

On Sun, Oct 14, 2018 at 10:38:36PM +0200, Daniel Lezcano wrote:
> On 14/10/2018 18:26, Guo Ren wrote:
> Thanks Guo,
> 
> the descriptions look ok for the timer part. Can you resend the DT
> bindings + timers patches separately with the commit log updated ?
Ok, immediately.

> 
> When you add the Changelog you have to insert it *after* the first
> '---', so when the patch is git applied, the change log will be
> discarded and won't appear in git.
Ok, thx for the tips.

> 
> eg.
> 
> commit 6b465856936cb8f7eda31b20eb59fb5c8a19d468
> Author: Guo Ren <ren_guo@c-sky.com>
> Date:   Tue Oct 2 16:43:18 2018 +0800
> 
> clocksource: add gx6605s SOC system timer
> 
> The driver is for gx6605s SOC system timer and there are two
> same timers in gx6605s. We use one for clkevt and another one for
> clksrc.
> 
> The timer is mmio map to access, so we need give mmio address in dts.
> The counter at 0x0  offset is clock event. The counter at 0x40 offset is
> clock source.
> 
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> Changelog:
>      - pass checkpatch.pl
>      - Add COMIPLE_TEST in Kconfig
>      - no cast is needed for "struct clock_event_device *ce = dev"
>      - remove: extra space after (u64)
>      - Add License and Copyright
>      - Use timer-of framework
>      - Change name with upstream feedback
>      - Use clksource_mmio framework
> ---

Best Regards
 Guo Ren

      reply	other threads:[~2018-10-15  2:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12 12:02 [PATCH V12 0/8] C-SKY(csky) Linux Kernel Driver Guo Ren
2018-10-12 12:02 ` [PATCH V12 1/8] irqchip: add C-SKY SMP interrupt controller Guo Ren
2018-10-12 12:02 ` [PATCH V12 2/8] dt-bindings: interrupt-controller: C-SKY SMP intc Guo Ren
2018-10-12 12:02 ` [PATCH V12 3/8] irqchip: add C-SKY APB bus interrupt controller Guo Ren
2018-10-12 12:12 ` [PATCH V12 4/8] dt-bindings: interrupt-controller: C-SKY APB intc Guo Ren
2018-10-12 12:12 ` [PATCH V12 5/8] clocksource: add C-SKY SMP timer Guo Ren
2018-10-12 12:12 ` [PATCH V12 6/8] dt-bindings: timer: C-SKY Multi-processor timer Guo Ren
2018-10-12 12:12 ` [PATCH V12 7/8] clocksource: add gx6605s SOC system timer Guo Ren
2018-10-12 12:12 ` [PATCH V12 8/8] dt-bindings: timer: gx6605s SOC timer Guo Ren
2018-10-13 20:50 ` [PATCH V12 0/8] C-SKY(csky) Linux Kernel Driver Daniel Lezcano
2018-10-14 16:26   ` Guo Ren
2018-10-14 20:38     ` Daniel Lezcano
2018-10-15  2:32       ` Guo Ren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181015023234.GA24121@guoren-Inspiron-7460 \
    --to=ren_guo@c-sky.com \
    --cc=arnd@arndb.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=paul.burton@mips.com \
    --cc=peterz@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).