From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: rcu: Fix code listing in performance and scalability requirements
Date: Mon, 15 Oct 2018 10:36:33 -0700 [thread overview]
Message-ID: <20181015173633.GA2674@linux.ibm.com> (raw)
In-Reply-To: <20181015022942.224250-1-joel@joelfernandes.org>
On Sun, Oct 14, 2018 at 07:29:42PM -0700, Joel Fernandes (Google) wrote:
> The code listing under this section has a quick quiz that says line 19
> uses rcu_access_pointer, but the code listing itself does not. Fix this.
>
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Good eyes! Queued for the merge window after this coming one,
thank you!
Thanx, Paul
> ---
> .../RCU/Design/Requirements/Requirements.html | 2 +-
> kernel/sys.c | 16 ++++++++++++++++
> 2 files changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/RCU/Design/Requirements/Requirements.html b/Documentation/RCU/Design/Requirements/Requirements.html
> index 4fae55056c1d..f74a2233865c 100644
> --- a/Documentation/RCU/Design/Requirements/Requirements.html
> +++ b/Documentation/RCU/Design/Requirements/Requirements.html
> @@ -1596,7 +1596,7 @@ used in place of <tt>synchronize_rcu()</tt> as follows:
> 16 struct foo *p;
> 17
> 18 spin_lock(&gp_lock);
> -19 p = rcu_dereference(gp);
> +19 p = rcu_access_pointer(gp);
> 20 if (!p) {
> 21 spin_unlock(&gp_lock);
> 22 return false;
> --
> 2.19.0.605.g01d371f741-goog
>
prev parent reply other threads:[~2018-10-15 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 2:29 [PATCH] doc: rcu: Fix code listing in performance and scalability requirements Joel Fernandes (Google)
2018-10-15 17:36 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015173633.GA2674@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).