[PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[Lukasz Majewski]

Add Device Tree binding document for Liebherr's BK4 external SPI bus.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt

diff --git a/Documentation/devicetree/bindings/misc/lwn-bk4.txt b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
new file mode 100644
index 000000000000..d6a8c188c087
--- /dev/null
+++ b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
@@ -0,0 +1,26 @@
+* Liebherr's BK4 controller external SPI
+
+A device which handles data acquisition from compatible industrial
+peripherals.
+The SPI is used for data and management purposes in both master and
+slave modes.
+
+Required properties:
+
+- compatible : Should be "lwn,bk4"
+
+Required SPI properties:
+
+- reg : Should be address of the device chip select within
+  the controller.
+
+- spi-max-frequency : Maximum SPI clocking speed of device in Hz, should be
+  30MHz at most for the Liebherr's BK4 external bus.
+
+Example:
+
+spidev0: spi@0 {
+	compatible = "lwn,bk4";
+	spi-max-frequency = <30000000>;
+	reg = <0>;
+};
-- 
2.11.0

Re: [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

Dear All,

> Add Device Tree binding document for Liebherr's BK4 external SPI bus.
> 

Gentle ping...

> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
> ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt
> 
> diff --git a/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> b/Documentation/devicetree/bindings/misc/lwn-bk4.txt new file mode
> 100644 index 000000000000..d6a8c188c087
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> @@ -0,0 +1,26 @@
> +* Liebherr's BK4 controller external SPI
> +
> +A device which handles data acquisition from compatible industrial
> +peripherals.
> +The SPI is used for data and management purposes in both master and
> +slave modes.
> +
> +Required properties:
> +
> +- compatible : Should be "lwn,bk4"
> +
> +Required SPI properties:
> +
> +- reg : Should be address of the device chip select within
> +  the controller.
> +
> +- spi-max-frequency : Maximum SPI clocking speed of device in Hz,
> should be
> +  30MHz at most for the Liebherr's BK4 external bus.
> +
> +Example:
> +
> +spidev0: spi@0 {
> +	compatible = "lwn,bk4";
> +	spi-max-frequency = <30000000>;
> +	reg = <0>;
> +};




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[Shawn Guo]

On Fri, Sep 28, 2018 at 12:26:55AM +0200, Lukasz Majewski wrote:
> Add Device Tree binding document for Liebherr's BK4 external SPI bus.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

There should really be a patch series consisting of this one and spidev
change [1].

Since spidev has already been picked up, having a series including this
and dts change would be the second option.  With DT folks' ACK, I can
send bindings change together with DTS using it.

Shawn

[1] https://lkml.org/lkml/2018/9/28/48

> ---
>  Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt
> 
> diff --git a/Documentation/devicetree/bindings/misc/lwn-bk4.txt b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> new file mode 100644
> index 000000000000..d6a8c188c087
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> @@ -0,0 +1,26 @@
> +* Liebherr's BK4 controller external SPI
> +
> +A device which handles data acquisition from compatible industrial
> +peripherals.
> +The SPI is used for data and management purposes in both master and
> +slave modes.
> +
> +Required properties:
> +
> +- compatible : Should be "lwn,bk4"
> +
> +Required SPI properties:
> +
> +- reg : Should be address of the device chip select within
> +  the controller.
> +
> +- spi-max-frequency : Maximum SPI clocking speed of device in Hz, should be
> +  30MHz at most for the Liebherr's BK4 external bus.
> +
> +Example:
> +
> +spidev0: spi@0 {
> +	compatible = "lwn,bk4";
> +	spi-max-frequency = <30000000>;
> +	reg = <0>;
> +};
> -- 
> 2.11.0
> 

Re: [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]

Hi Shawn,

> On Fri, Sep 28, 2018 at 12:26:55AM +0200, Lukasz Majewski wrote:
> > Add Device Tree binding document for Liebherr's BK4 external SPI
> > bus.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>  
> 
> There should really be a patch series consisting of this one and
> spidev change [1].
> 
> Since spidev has already been picked up, having a series including
> this and dts change would be the second option.  With DT folks' ACK,
> I can send bindings change together with DTS using it.

Any option will work for me :-).

> 
> Shawn
> 
> [1] https://lkml.org/lkml/2018/9/28/48
> 
> > ---
> >  Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
> > ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > b/Documentation/devicetree/bindings/misc/lwn-bk4.txt new file mode
> > 100644 index 000000000000..d6a8c188c087
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > @@ -0,0 +1,26 @@
> > +* Liebherr's BK4 controller external SPI
> > +
> > +A device which handles data acquisition from compatible industrial
> > +peripherals.
> > +The SPI is used for data and management purposes in both master and
> > +slave modes.
> > +
> > +Required properties:
> > +
> > +- compatible : Should be "lwn,bk4"
> > +
> > +Required SPI properties:
> > +
> > +- reg : Should be address of the device chip select within
> > +  the controller.
> > +
> > +- spi-max-frequency : Maximum SPI clocking speed of device in Hz,
> > should be
> > +  30MHz at most for the Liebherr's BK4 external bus.
> > +
> > +Example:
> > +
> > +spidev0: spi@0 {
> > +	compatible = "lwn,bk4";
> > +	spi-max-frequency = <30000000>;
> > +	reg = <0>;
> > +};
> > -- 
> > 2.11.0
> >   


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 2725 bytes --]

Dear All,

> Hi Shawn,
> 
> > On Fri, Sep 28, 2018 at 12:26:55AM +0200, Lukasz Majewski wrote:  
> > > Add Device Tree binding document for Liebherr's BK4 external SPI
> > > bus.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>    
> > 
> > There should really be a patch series consisting of this one and
> > spidev change [1].
> > 
> > Since spidev has already been picked up, having a series including
> > this and dts change would be the second option.  With DT folks' ACK,
> > I can send bindings change together with DTS using it.  
> 
> Any option will work for me :-).

Gentle ping on this patch (as corresponding DTS file has been already
pulled by Shawn).

Thanks in advance,

> 
> > 
> > Shawn
> > 
> > [1] https://lkml.org/lkml/2018/9/28/48
> >   
> > > ---
> > >  Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
> > > ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > > 
> > > diff --git a/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > > b/Documentation/devicetree/bindings/misc/lwn-bk4.txt new file mode
> > > 100644 index 000000000000..d6a8c188c087
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/misc/lwn-bk4.txt
> > > @@ -0,0 +1,26 @@
> > > +* Liebherr's BK4 controller external SPI
> > > +
> > > +A device which handles data acquisition from compatible
> > > industrial +peripherals.
> > > +The SPI is used for data and management purposes in both master
> > > and +slave modes.
> > > +
> > > +Required properties:
> > > +
> > > +- compatible : Should be "lwn,bk4"
> > > +
> > > +Required SPI properties:
> > > +
> > > +- reg : Should be address of the device chip select within
> > > +  the controller.
> > > +
> > > +- spi-max-frequency : Maximum SPI clocking speed of device in Hz,
> > > should be
> > > +  30MHz at most for the Liebherr's BK4 external bus.
> > > +
> > > +Example:
> > > +
> > > +spidev0: spi@0 {
> > > +	compatible = "lwn,bk4";
> > > +	spi-max-frequency = <30000000>;
> > > +	reg = <0>;
> > > +};
> > > -- 
> > > 2.11.0
> > >     
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

On Mon, Oct 15, 2018 at 12:17:16PM +0200, Lukasz Majewski wrote:

> Gentle ping on this patch (as corresponding DTS file has been already
> pulled by Shawn).

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[Rob Herring]

On Fri, Sep 28, 2018 at 12:26:55AM +0200, Lukasz Majewski wrote:
> Add Device Tree binding document for Liebherr's BK4 external SPI bus.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26 ++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/lwn-bk4.txt

Applied.

To add to Mark's comments, the status of binding patches can be checked 
on patchwork[1]. There's no reason for pings to me. If it is in the 
"New" state, I will get to it and you can see where you are in the 
queue. ATM, I'm rather backed up.

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/

Re: [PATCH] dt-bindings: misc: bk4: Add device tree binding for Liebherr's BK4 SPI bus

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

Hi All,

> On Fri, Sep 28, 2018 at 12:26:55AM +0200, Lukasz Majewski wrote:
> > Add Device Tree binding document for Liebherr's BK4 external SPI
> > bus.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >  Documentation/devicetree/bindings/misc/lwn-bk4.txt | 26
> > ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/misc/lwn-bk4.txt  
> 
> Applied.
> 
> To add to Mark's comments, the status of binding patches can be
> checked on patchwork[1]. There's no reason for pings to me. If it is
> in the "New" state, I will get to it and you can see where you are in
> the queue. ATM, I'm rather backed up.

Thanks for explanation and the hint regarding patchwork usage.

> 
> Rob
> 
> [1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]