From: Sergei Trofimovich <slyfox@gentoo.org>
To: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ia64: disable SCHED_STACK_END_CHECK
Date: Mon, 15 Oct 2018 20:14:41 +0100 [thread overview]
Message-ID: <20181015201441.64f6816a@sf> (raw)
In-Reply-To: <20180914070617.29203-1-slyfox@gentoo.org>
On Fri, 14 Sep 2018 08:06:17 +0100
Sergei Trofimovich <slyfox@gentoo.org> wrote:
> SCHED_STACK_END_CHECK assumes stack grows in one direction.
> ia64 is a rare case where it is not.
>
> As a result kernel fails at startup as:
> Kernel panic - not syncing: corrupted stack end detected inside scheduler
>
> The error does not find a real problem: it's register backing store
> is written on top of canary value.
>
> Disable SCHED_STACK_END_CHECK on ia64 as there is no good
> place for canary without moving initial stack address.
>
> CC: Tony Luck <tony.luck@intel.com>
> CC: Fenghua Yu <fenghua.yu@intel.com>
> CC: linux-ia64@vger.kernel.org
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 4966c4fbe7f7..a097dfe38d2b 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1004,7 +1004,7 @@ config SCHEDSTATS
>
> config SCHED_STACK_END_CHECK
> bool "Detect stack corruption on calls to schedule()"
> - depends on DEBUG_KERNEL
> + depends on DEBUG_KERNEL && !IA64
> default n
> help
> This option checks for a stack overrun on calls to schedule().
> --
> 2.19.0
>
Ping.
--
Sergei
prev parent reply other threads:[~2018-10-15 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 7:06 [PATCH] ia64: disable SCHED_STACK_END_CHECK Sergei Trofimovich
2018-10-15 19:14 ` Sergei Trofimovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015201441.64f6816a@sf \
--to=slyfox@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).