linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gustavo@embeddedor.com
Cc: quentin.schulz@bootlin.com, linux-kernel@vger.kernel.org,
	andrew@lunn.ch, f.fainelli@gmail.com
Subject: Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init
Date: Tue, 16 Oct 2018 09:54:14 -0700 (PDT)	[thread overview]
Message-ID: <20181016.095414.697502448536323380.davem@davemloft.net> (raw)
In-Reply-To: <e64b93c2-4f25-ee68-ef23-e947f1e84d55@embeddedor.com>

From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Tue, 16 Oct 2018 10:49:36 +0200

> Hi,
> 
> On 10/10/18 10:34 AM, Quentin Schulz wrote:
>> Hi Gustavo,
>> 
>> On Wed, Oct 10, 2018 at 10:31:39AM +0200, Gustavo A. R. Silva wrote:
>>> In case memory resources for *fw* were successfully allocated,
>>> release them before return.
>>>
>>> Addresses-Coverity-ID: 1473968 ("Resource leak")
>>> Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY")
>> 
>> Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
>> 
> 
> Friendly ping. Dave, can you take this?

It needs to be posted properly to netdev, just like all networking
patches do.

  reply	other threads:[~2018-10-16 16:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  8:29 [PATCH net-next v2 0/2] fix signedness bug and memory leak in mscc driver Gustavo A. R. Silva
2018-10-10  8:30 ` [PATCH net-next v2 1/2] net: phy: mscc: fix signedness bug in vsc85xx_downshift_get Gustavo A. R. Silva
2018-10-16  8:51   ` Gustavo A. R. Silva
2018-10-10  8:31 ` [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init Gustavo A. R. Silva
2018-10-10  8:34   ` Quentin Schulz
2018-10-16  8:49     ` Gustavo A. R. Silva
2018-10-16 16:54       ` David Miller [this message]
2018-10-16 17:03         ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181016.095414.697502448536323380.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quentin.schulz@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).