From: Mark Brown <broonie@kernel.org>
To: Trent Piepho <tpiepho@impinj.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"phil@raspberrypi.org" <phil@raspberrypi.org>
Subject: Re: [PATCH] spi: Make GPIO CSs honour the SPI_NO_CS flag
Date: Tue, 16 Oct 2018 10:03:10 +0100 [thread overview]
Message-ID: <20181016090310.GA7449@sirena.org.uk> (raw)
In-Reply-To: <1539628457.30311.5.camel@impinj.com>
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
On Mon, Oct 15, 2018 at 06:34:18PM +0000, Trent Piepho wrote:
> What about the calls to spi->controller->set_cs() after this? Should a
> driver provided set_cs method be responsible for checking SPI_NO_CS?
> Or should it not be called in the first place?
This seems like something that should be done entirely in the framework,
no point in every single driver having to open code the same thing.
> I imagine it depends on what set_cs needs to do, which might not be
> solely related to changing the CS line.
It should be. If something is hanging other work on set_cs() then it's
going to break.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-10-16 9:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 9:23 [PATCH] spi: Make GPIO CSs honour the SPI_NO_CS flag Phil Elwell
2018-10-12 17:03 ` Applied "spi: Make GPIO CSs honour the SPI_NO_CS flag" to the spi tree Mark Brown
2018-10-15 18:34 ` [PATCH] spi: Make GPIO CSs honour the SPI_NO_CS flag Trent Piepho
2018-10-16 9:03 ` Mark Brown [this message]
2018-10-16 19:29 ` Trent Piepho
2018-10-17 9:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016090310.GA7449@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=phil@raspberrypi.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).