From: Greg KH <gregkh@linuxfoundation.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: "idryomov@gmail.com" <idryomov@gmail.com>,
"sage@redhat.com" <sage@redhat.com>,
"elder@kernel.org" <elder@kernel.org>,
"jth@kernel.org" <jth@kernel.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] driver core: device: add BUS_ATTR_WO macro
Date: Tue, 16 Oct 2018 12:48:14 +0200 [thread overview]
Message-ID: <20181016104814.GA4768@kroah.com> (raw)
In-Reply-To: <HE1PR0401MB236354F325B7A56355068E35E0E80@HE1PR0401MB2363.eurprd04.prod.outlook.com>
On Tue, Oct 02, 2018 at 09:43:35AM +0000, Ioana Ciornei wrote:
> > > Add BUS_ATTR_WO macro to make it easier to add attributes without
> > > auditing the mode settings. Also, use the newly added macro where
> > > appropriate.
> > >
> > > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > > ---
> > > arch/powerpc/platforms/pseries/ibmebus.c | 12 ++++----
> > > drivers/block/rbd.c | 48 ++++++++++++++++----------------
> > > drivers/scsi/fcoe/fcoe_sysfs.c | 4 +--
> > > drivers/scsi/fcoe/fcoe_transport.c | 10 +++----
> > > include/linux/device.h | 2 ++
> > > include/scsi/libfcoe.h | 8 +++---
> > > 6 files changed, 43 insertions(+), 41 deletions(-)
> >
> > Nice! This duplicates a lot of the work I did back in July but have not pushed out
> > very far due to the other things that ended up happening around that time:
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/log/?h=bus_cleanup
> >
> > As the patch series seen at that link shows, you can do this in more places than
> > just what you did here.
> >
> > Either way, you should break this up into the individual patches, like I did or you
> > can take my patches if you want. Getting the BUS_ATTR_WO() macro added is
> > good to do now, and then you can go and hit up all of the different subsystems
> > that should be converted over to it.
>
> I can of course split my patch into individual ones and resubmit them, but as you already have the entire patch set ready, I feel like we can just push those. I looked through your changes and it seems like you covered all the subsystems. Please let me know if there is something else I should do.
>
> My intention here was to first add the _WO attribute so that afterwards I can add a new bus attribute in the fsl-mc bus.
Ok, I've queued up the patch that adds the _WO attribute now, so that
you should be able to use this after 4.20-rc1. I'll work on getting my
other patches merged in that series at that time as well.
thanks,
greg k-h
prev parent reply other threads:[~2018-10-16 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 15:32 [PATCH] driver core: device: add BUS_ATTR_WO macro Ioana Ciornei
2018-10-01 21:08 ` Greg KH
2018-10-02 9:43 ` Ioana Ciornei
2018-10-16 10:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016104814.GA4768@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benh@kernel.crashing.org \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@kernel.org \
--cc=idryomov@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jth@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sage@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).