From: Wei Yang <richard.weiyang@gmail.com>
To: Peng Hao <peng.hao2@zte.com.cn>
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, tglx@linutronix.de,
x86@kernel.org, hpa@zytor.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2] kvm:x86 :remove unnecessary recalculate_apic_map
Date: Tue, 16 Oct 2018 12:49:19 +0000 [thread overview]
Message-ID: <20181016124919.3qgn6a4g7y2srd7k@master> (raw)
In-Reply-To: <1539681150-9374-1-git-send-email-peng.hao2@zte.com.cn>
On Tue, Oct 16, 2018 at 05:12:30PM +0800, Peng Hao wrote:
>In the previous code, the variable sw_apic_disabled influences
>recalculate_apic_map. But in "KVM: x86: simplify kvm_apic_map"
>(commit:3b5a5ffa928a3f875b0d5dd284eeb7c322e1688a),
>the access to sw_apic_disabled in recalculate_apic_map has been
>deleted.
s/sw_apic_disabled/apic_sw_disabled/ ?
>
>Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
>---
> arch/x86/kvm/lapic.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
>index 70dcb55..0380e37 100644
>--- a/arch/x86/kvm/lapic.c
>+++ b/arch/x86/kvm/lapic.c
>@@ -246,10 +246,9 @@ static inline void apic_set_spiv(struct kvm_lapic *apic, u32 val)
>
> if (enabled != apic->sw_enabled) {
> apic->sw_enabled = enabled;
>- if (enabled) {
>+ if (enabled)
> static_key_slow_dec_deferred(&apic_sw_disabled);
>- recalculate_apic_map(apic->vcpu->kvm);
>- } else
>+ else
> static_key_slow_inc(&apic_sw_disabled.key);
> }
> }
>--
>1.8.3.1
--
Wei Yang
Help you, Help me
prev parent reply other threads:[~2018-10-16 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 9:12 [PATCH v2] kvm:x86 :remove unnecessary recalculate_apic_map Peng Hao
2018-10-16 12:49 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016124919.3qgn6a4g7y2srd7k@master \
--to=richard.weiyang@gmail.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peng.hao2@zte.com.cn \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).