From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: heiko@sntech.de, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Vicente Bergas <vicencb@gmail.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] DT: rockchip: Fix stability issues with the 'performance' governor on rock960
Date: Tue, 16 Oct 2018 19:51:38 +0530 [thread overview]
Message-ID: <20181016142138.GA24727@mani> (raw)
In-Reply-To: <1539698431-12616-1-git-send-email-daniel.lezcano@linaro.org>
On Tue, Oct 16, 2018 at 04:00:20PM +0200, Daniel Lezcano wrote:
> When the performance governor is set as default, the rock960 hangs
> around one minute after booting, whatever the activity is (idle, key
> pressed, loaded, ...).
>
> Based on the commit log found at https://patchwork.kernel.org/patch/10092377/
>
> "vdd_log has no consumer and therefore will not be set to a specific
> voltage. Still the PWM output pin gets configured and thence the vdd_log
> output voltage will changed from it's default. Depending on the idle
> state of the PWM this will slightly over or undervoltage the logic supply
> of the RK3399 and cause instability with GbE (undervoltage) and PCIe
> (overvoltage). Since the default value set by a voltage divider is the
> correct supply voltage and we don't need to change it during runtime we
> remove the rail from the devicetree completely so the PWM pin will not
> be configured."
>
> After removing the vdd-log from the rock960's specific DT, the board
> does no longer hang and shows a stable behavior.
>
> Apply the same change for the rock960 by removing the vdd-log from the
> DT.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Tested on Rock960 v1.2 board, hence
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks a ton!
Regards,
Mani
> ---
> arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> index 6c8c4ab..56abbb0 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> @@ -57,18 +57,6 @@
> regulator-always-on;
> vin-supply = <&vcc_sys>;
> };
> -
> - vdd_log: vdd-log {
> - compatible = "pwm-regulator";
> - pwms = <&pwm2 0 25000 0>;
> - regulator-name = "vdd_log";
> - regulator-min-microvolt = <800000>;
> - regulator-max-microvolt = <1400000>;
> - regulator-always-on;
> - regulator-boot-on;
> - vin-supply = <&vcc_sys>;
> - };
> -
> };
>
> &cpu_l0 {
> --
> 2.7.4
>
prev parent reply other threads:[~2018-10-16 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 14:00 [PATCH] DT: rockchip: Fix stability issues with the 'performance' governor on rock960 Daniel Lezcano
2018-10-16 14:21 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181016142138.GA24727@mani \
--to=manivannan.sadhasivam@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).