From: kbuild test robot <lkp@intel.com>
To: shubhrajyoti.datta@gmail.com
Cc: kbuild-all@01.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jslaby@suse.com, jacmet@sunsite.dk,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [LINUX PATCHv3 6/9] serial-uartlite: Change logic how console_port is setup
Date: Tue, 16 Oct 2018 22:09:22 +0800 [thread overview]
Message-ID: <201810162255.Jmmf96Pl%fengguang.wu@intel.com> (raw)
In-Reply-To: <1539685088-13465-7-git-send-email-shubhrajyoti.datta@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3466 bytes --]
Hi Shubhrajyoti,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on next-20181016]
[cannot apply to v4.19-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/shubhrajyoti-datta-gmail-com/serial-uartlite-Add-support-for-dynamic-allocation/20181016-210709
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: i386-randconfig-x019-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
Note: the linux-review/shubhrajyoti-datta-gmail-com/serial-uartlite-Add-support-for-dynamic-allocation/20181016-210709 HEAD 7aba44c5f67836025decfe4dc4ab364c1f83f44d builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>):
In file included from include/linux/ioport.h:13:0,
from include/linux/device.h:15,
from include/linux/platform_device.h:14,
from drivers/tty//serial/uartlite.c:9:
drivers/tty//serial/uartlite.c: In function 'ulite_assign':
>> drivers/tty//serial/uartlite.c:684:25: error: invalid type argument of '->' (have 'struct uart_driver')
!(ulite_uart_driver->cons->flags & CON_ENABLED))
^
include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/tty//serial/uartlite.c:683:2: note: in expansion of macro 'if'
if (console_port == port &&
^~
>> drivers/tty//serial/uartlite.c:684:25: error: invalid type argument of '->' (have 'struct uart_driver')
!(ulite_uart_driver->cons->flags & CON_ENABLED))
^
include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/tty//serial/uartlite.c:683:2: note: in expansion of macro 'if'
if (console_port == port &&
^~
>> drivers/tty//serial/uartlite.c:684:25: error: invalid type argument of '->' (have 'struct uart_driver')
!(ulite_uart_driver->cons->flags & CON_ENABLED))
^
include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> drivers/tty//serial/uartlite.c:683:2: note: in expansion of macro 'if'
if (console_port == port &&
^~
vim +684 drivers/tty//serial/uartlite.c
671
672 /* Register the port */
673 rc = uart_add_one_port(&ulite_uart_driver, port);
674 if (rc) {
675 dev_err(dev, "uart_add_one_port() failed; err=%i\n", rc);
676 port->mapbase = 0;
677 dev_set_drvdata(dev, NULL);
678 return rc;
679 }
680
681 #ifdef CONFIG_SERIAL_UARTLITE_CONSOLE
682 /* This is not port which is used for console that's why clean it up */
> 683 if (console_port == port &&
> 684 !(ulite_uart_driver->cons->flags & CON_ENABLED))
685 console_port = NULL;
686 #endif
687
688 return 0;
689 }
690
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28007 bytes --]
next prev parent reply other threads:[~2018-10-16 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 10:17 [LINUX PATCHv3 0/9] serial-uartlite: Add support for dynamic allocation shubhrajyoti.datta
2018-10-16 10:18 ` [LINUX PATCHv3 1/9] serial-uartlite: Move the uart register shubhrajyoti.datta
2018-10-16 10:18 ` [LINUX PATCHv3 2/9] serial-uartlite: Add get serial id if not provided shubhrajyoti.datta
2018-10-16 10:18 ` [LINUX PATCHv3 3/9] serial-uartlite: Do not use static struct uart_driver out of probe() shubhrajyoti.datta
2018-10-16 10:18 ` [LINUX PATCHv3 4/9] serial-uartlite: Add runtime support shubhrajyoti.datta
2018-10-16 10:18 ` [LINUX PATCHv3 5/9] serial-uartlite: Fix the unbind path shubhrajyoti.datta
2018-10-16 10:18 ` [LINUX PATCHv3 6/9] serial-uartlite: Change logic how console_port is setup shubhrajyoti.datta
2018-10-16 14:09 ` kbuild test robot [this message]
2018-10-16 10:18 ` [LINUX PATCHv3 7/9] serial-uartlite: Use allocated structure instead of static ones shubhrajyoti.datta
2018-10-16 10:18 ` [LINUX PATCHv3 8/9] serial-uartlite: Remove ULITE_NR_PORTS macro shubhrajyoti.datta
2018-10-16 10:18 ` [LINUX PATCHv3 9/9] serial-uartlite: Remove SERIAL_UARTLITE_NR_UARTS shubhrajyoti.datta
2018-11-09 16:45 ` [LINUX PATCHv3 0/9] serial-uartlite: Add support for dynamic allocation Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201810162255.Jmmf96Pl%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacmet@sunsite.dk \
--cc=jslaby@suse.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).