From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB98C5ACCC for ; Tue, 16 Oct 2018 23:49:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB7B02148C for ; Tue, 16 Oct 2018 23:49:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB7B02148C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727274AbeJQHmL (ORCPT ); Wed, 17 Oct 2018 03:42:11 -0400 Received: from mga07.intel.com ([134.134.136.100]:14574 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727064AbeJQHmL (ORCPT ); Wed, 17 Oct 2018 03:42:11 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 16:49:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,389,1534834800"; d="scan'208";a="241889366" Received: from romley-ivt3.sc.intel.com ([172.25.110.60]) by orsmga004.jf.intel.com with ESMTP; 16 Oct 2018 16:49:22 -0700 Date: Tue, 16 Oct 2018 16:45:56 -0700 From: Fenghua Yu To: "Moger, Babu" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "reinette.chatre@intel.com" , "fenghua.yu@intel.com" , "james.morse@arm.com" , "tony.luck@intel.com" , "corbet@lwn.net" , "x86@kernel.org" , "peterz@infradead.org" , "pombredanne@nexb.com" , "gregkh@linuxfoundation.org" , "kstewart@linuxfoundation.org" , "bp@suse.de" , "rafael.j.wysocki@intel.com" , "ak@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "xiaochen.shen@intel.com" , "colin.king@canonical.com" , "Hurwitz, Sherry" , "Lendacky, Thomas" , "pbonzini@redhat.com" , "dwmw@amazon.co.uk" , "luto@kernel.org" , "jroedel@suse.de" , "jannh@google.com" , "dima@arista.com" , "jpoimboe@redhat.com" , "vkuznets@redhat.com" , "linux-kernel@vger.kernel.org" , "mchehab+samsung@kernel.org" , "davem@davemloft.net" , "akpm@linux-foundation.org" , "arnd@arndb.de" Subject: Re: [PATCH v4 08/13] arch/x86: Bring few more functions into the resource structure Message-ID: <20181016234556.GB39177@romley-ivt3.sc.intel.com> References: <20181015205514.25387-1-babu.moger@amd.com> <20181015205514.25387-9-babu.moger@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181015205514.25387-9-babu.moger@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 15, 2018 at 08:55:49PM +0000, Moger, Babu wrote: > update_mba_bw : Feedback loop bandwidth update functionality is not > needed for AMD. Will you implement update_mba_bw() for AMD in future? > list_for_each_entry(crgrp, head, mon.crdtgrp_list) > mbm_update(d, crgrp->mon.rmid); > > - if (is_mba_sc(NULL)) > - update_mba_bw(prgrp, d); > + if (is_mba_sc(NULL)) { > + r_mba = &rdt_resources_all[RDT_RESOURCE_MBA]; > + if (r_mba->update_mba_bw) > + r_mba->update_mba_bw(prgrp, d); > + } Mount option "mba_MBps" is not implemented on AMD. Then don't call set_mba_sc(true) in parse_rdtgroupfs_options(). Thus, you don't need to change this code here because is_mba_sc(NULL) is false on AMD. Thanks. -Fenghua