From: Antoine Tenart <antoine.tenart@bootlin.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Kees Cook <keescook@chromium.org>,
Antoine Tenart <antoine.tenart@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto <linux-crypto@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: inside-secure: safexcel - fix memory allocation
Date: Wed, 17 Oct 2018 09:20:34 +0200 [thread overview]
Message-ID: <20181017072034.GD28572@kwain> (raw)
In-Reply-To: <20181017061741.qr23stkwqf36fet6@gondor.apana.org.au>
Hi,
On Wed, Oct 17, 2018 at 02:17:41PM +0800, Herbert Xu wrote:
> On Tue, Oct 16, 2018 at 09:44:02PM +0200, Gustavo A. R. Silva wrote:
> > On 10/9/18 12:20 AM, Kees Cook wrote:
> > > On Mon, Oct 8, 2018 at 12:17 PM, Gustavo A. R. Silva
> > > <gustavo@embeddedor.com> wrote:
> > >> The original intention is to allocate space for EIP197_DEFAULT_RING_SIZE
> > >> *pointers* to struct, so sizeof(priv->ring[i].rdr_req) should be
> > >> sizeof(*priv->ring[i].rdr_req).
> > >>
> > >> Addresses-Coverity-ID: 1473962 ("Sizeof not portable")
> > >> Fixes: 9744fec95f06 ("crypto: inside-secure - remove request list to improve performance")
> > >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > >
> > > Reviewed-by: Kees Cook <keescook@chromium.org>
> > >
> >
> >
> > Friendly ping. Who can take this?
>
> Well I tried to take it but it doesn't apply against cryptodev.
> So I presume this can go into the tree that carried the change
> which it depended on?
I would say this should go in cryptodev. The issue is probably because
of other changes that got applied in the meantime. Gustavo can probably
rebase his patch on top of cryptodev, and re-send it.
Thanks!
Antoine
--
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-17 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 19:17 [PATCH] crypto: inside-secure: safexcel - fix memory allocation Gustavo A. R. Silva
2018-10-08 22:20 ` Kees Cook
2018-10-16 19:44 ` Gustavo A. R. Silva
2018-10-17 6:17 ` Herbert Xu
2018-10-17 7:20 ` Antoine Tenart [this message]
2018-10-17 14:41 ` Gustavo A. R. Silva
2018-10-17 18:23 ` Kees Cook
2018-10-18 6:24 ` Gustavo A. R. Silva
2018-10-10 13:55 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017072034.GD28572@kwain \
--to=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).