From: Rob Herring <robh@kernel.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lubomir Rintel <lkundrak@v3.sk>
Subject: Re: [PATCH 2/2] misc: hx8837: add a HiMax HX8837 display controller driver
Date: Wed, 17 Oct 2018 09:07:44 -0500 [thread overview]
Message-ID: <20181017140744.GA21328@bogus> (raw)
In-Reply-To: <20181008202321.128937-2-lkundrak@v3.sk>
On Mon, 8 Oct 2018 22:23:21 +0200, Lubomir Rintel wrote:
> HiMax HX8837 is a display controller used on OLPC platforms. It controlls
> backlight and is able to capture and freeze a frame when the LCD controller
> (and the rest of the plaform) is powered off.
>
> This driver is based on the same code as drivers/staging/olpc_dcon.
> I modernized it to use managed GPIO, device-tree bindings, sysfs attribtue
> groups, essentially fixing the staging driver's TODO.
>
> Why I am not removing the staging driver now is because I've hobbled off
> some functionality too (with an intent to bring add it back eventually):
>
> * I've removed parts that talk directly to the OLPC EC to turn off/on the
> power. A separate patch will make the EC expose a regulator interface
> that should be used instead.
>
> * Some work is likely needed to make XO 1 and XO 1.5 work. Both platforms
> are DT-based and could use the same bindings, but I haven't checked
> whether the cs5535 and vx855 GPIO drivers are good enough.
>
> What is there is the backlight control and the sysfs attributes to control
> the freeze/unfreeze..
>
> I've also renamed the driver to use the actual chip name instead of the
> original name that I found too generic. This way the staging driver can be
> used on XO 1 and XO 1.5 for the time being, while my XO 1.75 can utilize
> this one.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> Changes since v1:
> - Use interrupt bindings instead of gpio for the IRQ
> - Update the statement on XO 1/1.5 support in the commit message
>
> drivers/misc/Kconfig | 16 +
> drivers/misc/Makefile | 1 +
> drivers/misc/hx8837.c | 741 ++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 758 insertions(+)
> create mode 100644 drivers/misc/hx8837.c
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2018-10-17 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 20:23 [PATCH 1/2] dt-bindings: himax,hx8837: add HiMax HX8837 bindings Lubomir Rintel
2018-10-08 20:23 ` [PATCH 2/2] misc: hx8837: add a HiMax HX8837 display controller driver Lubomir Rintel
2018-10-17 14:07 ` Rob Herring [this message]
2018-11-05 9:19 ` [PATCH 1/2] dt-bindings: himax,hx8837: add HiMax HX8837 bindings Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2018-11-12 2:39 [PATCH v3 " Lubomir Rintel
2018-11-12 2:39 ` [PATCH 2/2] misc: hx8837: add a HiMax HX8837 display controller driver Lubomir Rintel
2018-11-27 7:41 ` Greg Kroah-Hartman
2018-12-18 15:28 ` Lubomir Rintel
2018-09-18 20:43 [PATCH 1/2] dt-bindings: himax,hx8837: add HiMax HX8837 bindings Lubomir Rintel
2018-09-18 20:43 ` [PATCH 2/2] misc: hx8837: add a HiMax HX8837 display controller driver Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017140744.GA21328@bogus \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).