linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Quentin Schulz <quentin.schulz@bootlin.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1
Date: Wed, 17 Oct 2018 10:23:54 -0500	[thread overview]
Message-ID: <20181017152354.GA9268@bogus> (raw)
In-Reply-To: <20181017150931.GA385@bogus>

On Wed, Oct 17, 2018 at 10:09:31AM -0500, Rob Herring wrote:
> On Tue, Oct 16, 2018 at 10:44:52AM +0200, Gustavo A. R. Silva wrote:
> > Hi,
> > 
> > On 10/9/18 9:27 AM, Quentin Schulz wrote:
> > > Hi Gustavo,
> > > 
> > > On Tue, Oct 09, 2018 at 12:21:36AM +0200, Gustavo A. R. Silva wrote:
> > >> SERDES_MAX is a valid value to index ctrl->phys in
> > >> drivers/phy/mscc/phy-ocelot-serdes.c. But, currently,
> > >> there is an out-of-bounds bug in the mentioned driver
> > >> when reading from ctrl->phys, because the size of
> > >> array ctrl->phys is SERDES_MAX.
> > >>
> > >> Partially fix this by updating SERDES_MAX to be SERDES6G_MAX + 1.
> > >>
> > >> Notice that this is the first part of the solution to
> > >> the out-of-bounds bug mentioned above. Although this
> > >> change is not dependent on any other one.
> > >>
> > > 
> > > Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
> > > 
> > 
> > Friendly ping. Who can you take this?
> 
> Applied. No need (nor benefit) to ping me. You can check the status of 
> DT patches on patchwork[1]. If it is there and in the "New" state, it is 
> in my queue.

Actually, this doesn't apply to my tree as the file doesn't exist. It 
needs to go thru the phy tree. You didn't Cc the maintainer nor list, so 
resend.

Acked-by: Rob Herring <robh@kernel.org>

Rob

  parent reply	other threads:[~2018-10-17 15:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 22:20 [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug Gustavo A. R. Silva
2018-10-08 22:21 ` [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1 Gustavo A. R. Silva
2018-10-09  7:27   ` Quentin Schulz
2018-10-16  8:44     ` Gustavo A. R. Silva
2018-10-17 15:09       ` Rob Herring
2018-10-17 15:19         ` Gustavo A. R. Silva
2018-10-17 15:23         ` Rob Herring [this message]
2018-10-17 15:45           ` Gustavo A. R. Silva
2018-10-08 22:22 ` [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read Gustavo A. R. Silva
2018-10-09  7:28   ` Quentin Schulz
2018-10-16  8:46     ` Gustavo A. R. Silva
2018-10-16  8:48       ` Kishon Vijay Abraham I
2018-10-17 15:37         ` Gustavo A. R. Silva
2018-11-12  8:27           ` Kishon Vijay Abraham I
2018-10-09  7:28 ` [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug Quentin Schulz
2018-10-09 14:13   ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181017152354.GA9268@bogus \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=quentin.schulz@bootlin.com \
    --subject='Re: [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).