From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] hwmon: (core) Inherit power properties to hdev
Date: Wed, 17 Oct 2018 13:15:02 -0700 [thread overview]
Message-ID: <20181017201501.GA15941@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20181017194430.GA6812@roeck-us.net>
On Wed, Oct 17, 2018 at 12:44:30PM -0700, Guenter Roeck wrote:
> > + hdev->driver = dev->driver;
> > + hdev->power = dev->power;
> > + hdev->pm_domain = dev->pm_domain;
>
> dev can, unfortunately, be NULL
>
> > hdev->of_node = dev ? dev->of_node : NULL;
>
> ... as you can see here.
Oops..will fix it.
Thanks!
>
> Guenter
>
> > hwdev->chip = chip;
> > dev_set_drvdata(hdev, drvdata);
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2018-10-17 20:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 1:24 [PATCH 0/5] hwmon: (ina3221) Implement PM runtime to save power Nicolin Chen
2018-10-17 1:24 ` [PATCH 1/5] hwmon: (core) Inherit power properties to hdev Nicolin Chen
2018-10-17 19:44 ` Guenter Roeck
2018-10-17 20:15 ` Nicolin Chen [this message]
2018-10-18 11:37 ` Dan Carpenter
2018-10-17 1:24 ` [PATCH 2/5] hwmon: (ina3221) Return -ENODATA for two alarms attributes Nicolin Chen
2018-10-17 19:46 ` Guenter Roeck
2018-10-17 20:39 ` Nicolin Chen
2018-10-17 21:14 ` Guenter Roeck
2018-10-18 1:03 ` Nicolin Chen
2018-10-17 1:24 ` [PATCH 3/5] hwmon: (ina3221) Serialize sysfs ABI accesses Nicolin Chen
2018-10-17 1:24 ` [PATCH 4/5] hwmon: (ina3221) Make sure data is ready after channel enabling Nicolin Chen
2018-10-17 16:55 ` Guenter Roeck
2018-10-17 20:53 ` Nicolin Chen
2018-10-17 21:17 ` Guenter Roeck
2018-10-18 1:04 ` Nicolin Chen
2018-10-17 1:24 ` [PATCH 5/5] hwmon: (ina3221) Add PM runtime support Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017201501.GA15941@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).