From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65551ECDE3D for ; Thu, 18 Oct 2018 03:18:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D62621470 for ; Thu, 18 Oct 2018 03:18:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D62621470 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727360AbeJRLQ4 (ORCPT ); Thu, 18 Oct 2018 07:16:56 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:44425 "EHLO smtp2200-217.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727260AbeJRLQ4 (ORCPT ); Thu, 18 Oct 2018 07:16:56 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.0877228|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03275;MF=ren_guo@c-sky.com;NM=1;PH=DS;RN=16;RT=16;SR=0;TI=SMTPD_---.D3jsMeD_1539832653; Received: from localhost(mailfrom:ren_guo@c-sky.com fp:SMTPD_---.D3jsMeD_1539832653) by smtp.aliyun-inc.com(10.147.41.158); Thu, 18 Oct 2018 11:17:33 +0800 Date: Thu, 18 Oct 2018 11:17:33 +0800 From: Guo Ren To: Arnd Bergmann Cc: Andrew Morton , Daniel Lezcano , David Miller , gregkh , Christoph Hellwig , Marc Zyngier , Mark Rutland , Peter Zijlstra , Rob Herring , Thomas Gleixner , Linux Kernel Mailing List , linux-arch , DTML , Rob Herring , c-sky_gcc_upstream@c-sky.com Subject: Re: [PATCH V9 15/21] csky: Debug and Ptrace GDB Message-ID: <20181018031733.GB15088@guoren-Inspiron-7460> References: <1963c845cf9b7aa31547cdfe1f82b1add1ad2504.1539655732.git.ren_guo@c-sky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 17, 2018 at 05:46:56PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:06 AM Guo Ren wrote: > > > > This patch adds arch ptrace implementation, stack dump and bug.h. > > > > Signed-off-by: Guo Ren > > Cc: Arnd Bergmann > > Reviewed-by: Arnd Bergmann > > > diff --git a/arch/csky/include/asm/bug.h b/arch/csky/include/asm/bug.h > > new file mode 100644 > > index 0000000..bd7b323 > > --- /dev/null > > +++ b/arch/csky/include/asm/bug.h > > @@ -0,0 +1,26 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +// Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > > + > > +#ifndef __ASM_CSKY_BUG_H > > +#define __ASM_CSKY_BUG_H > > + > > +#include > > +#include > > +#include > > + > > +#define BUG() \ > > +do { \ > > + asm volatile ("bkpt\n"); \ > > + unreachable(); \ > > +} while (0) > > Since you have a breakpoint instruction, a nice addition might > be to use that for implementing WARN_ON as well, whenever you > get around to doing that. It's certainly not required for the initial > merge. Thx for remind and I'll improve it next. Best Regards Guo Ren