archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <>
To: Linus Walleij <>,
	Mattias Wallin <>
Cc: Lee Jones <>,,,
Subject: [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible()
Date: Thu, 18 Oct 2018 11:05:34 +0300	[thread overview]
Message-ID: <20181018080534.yw2crvhguen5vajg@kili.mountain> (raw)

I just noticed this in review.  The get_register_interruptible() should
return zero on success but it instead returns the value that it read.

I looked at all the places that called this directly and they check for
negatives and treat greater than or equal to zero as success.  This
function is also called as the ->get_register() function pointer.  Some
of the callers of that treat all non-zero returns as errors, so it's
possible that this bug causes some problems in real life.

I could not find any callers that rely on the current behavior, and this
makes the function align with the get_register_interruptible() in

Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface")
Signed-off-by: Dan Carpenter <>
 drivers/mfd/ab8500-core.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index 30d09d177171..66458a329127 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -252,16 +252,18 @@ static int get_register_interruptible(struct ab8500 *ab8500, u8 bank,
 	ret = ab8500->read(ab8500, addr);
-	if (ret < 0)
+	if (ret < 0) {
 		dev_err(ab8500->dev, "failed to read reg %#x: %d\n",
 			addr, ret);
-	else
-		*value = ret;
+		return ret;
+	}
+	*value = ret;
 	dev_vdbg(ab8500->dev, "rd: addr %#x => data %#x\n", addr, ret);
-	return ret;
+	return 0;
 static int ab8500_get_register(struct device *dev, u8 bank,

             reply	other threads:[~2018-10-18  8:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18  8:05 Dan Carpenter [this message]
2018-10-25  8:25 ` [PATCH 2/2] mfd: ab8500-core: Return zero in get_register_interruptible() Lee Jones
2018-10-25  8:46   ` Dan Carpenter
2018-10-25 10:10     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181018080534.yw2crvhguen5vajg@kili.mountain \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).