From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF57C5ACCC for ; Thu, 18 Oct 2018 09:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E26B82098A for ; Thu, 18 Oct 2018 09:31:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E26B82098A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbeJRRbg (ORCPT ); Thu, 18 Oct 2018 13:31:36 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:36278 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727427AbeJRRbg (ORCPT ); Thu, 18 Oct 2018 13:31:36 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 72ED8806ED; Thu, 18 Oct 2018 11:31:24 +0200 (CEST) Date: Thu, 18 Oct 2018 11:31:25 +0200 From: Pavel Machek To: Borislav Petkov Cc: Randy Dunlap , Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Peter Zijlstra , "Ravi V. Shankar" , Vedvyas Shanbhogue Subject: Re: [PATCH v5 03/27] x86/fpu/xstate: Introduce XSAVES system states Message-ID: <20181018093125.GB10861@amd> References: <20181011151523.27101-1-yu-cheng.yu@intel.com> <20181011151523.27101-4-yu-cheng.yu@intel.com> <20181017104137.GE22535@zn.tnic> <32da559b-7958-60db-e328-f0eb316e668e@infradead.org> <20181017225829.GA32023@zn.tnic> <20181018092603.GB20831@zn.tnic> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CUfgB8w4ZwR/yMy5" Content-Disposition: inline In-Reply-To: <20181018092603.GB20831@zn.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CUfgB8w4ZwR/yMy5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2018-10-18 11:26:03, Borislav Petkov wrote: > On Wed, Oct 17, 2018 at 04:17:01PM -0700, Randy Dunlap wrote: > > I asked what I really wanted to know. >=20 > Then the answer is a bit better readability, I'd guess. Normally, similar local variables are grouped together, with initialized variables giving additional constraints. Additionally sorting them with length ... gives too much constraints to the author. We want readable sources, not neat ascii art everywhere. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --CUfgB8w4ZwR/yMy5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlvIUu0ACgkQMOfwapXb+vJZyACgn99kve8+2WEyYpLJ7yB+0qS+ ctcAoMNGUikTEw2fbI/IwxPsp3/Jpr6K =dsBJ -----END PGP SIGNATURE----- --CUfgB8w4ZwR/yMy5--