From: Juri Lelli <juri.lelli@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Juri Lelli <juri.lelli@gmail.com>,
syzbot <syzbot+385468161961cee80c31@syzkaller.appspotmail.com>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
mingo@redhat.com, nstange@suse.de,
syzkaller-bugs@googlegroups.com,
Luca Abeni <luca.abeni@santannapisa.it>,
henrik@austad.us,
Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
Claudio Scordino <claudio@evidence.eu.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: INFO: rcu detected stall in do_idle
Date: Thu, 18 Oct 2018 12:10:08 +0200 [thread overview]
Message-ID: <20181018101008.GB21611@localhost.localdomain> (raw)
In-Reply-To: <20181018094850.GW3121@hirez.programming.kicks-ass.net>
On 18/10/18 11:48, Peter Zijlstra wrote:
> On Thu, Oct 18, 2018 at 10:28:38AM +0200, Juri Lelli wrote:
>
> > Another side problem seems also to be that with such tiny parameters we
> > spend lot of time in the while (dl_se->runtime <= 0) loop of replenish_dl_
> > entity() (actually uselessly, as deadline is most probably going to
> > still be in the past when eventually runtime becomes positive again), as
> > delta_exec is huge w.r.t. runtime and runtime has to keep up with tiny
> > increments of dl_runtime. I guess we could ameliorate things here by
> > limiting the number of time we execute the loop before bailing out.
>
> That's the "DL replenish lagged too much" case, right? Yeah, there is
> only so much we can recover from.
Right.
> Funny that GCC actually emits that loop; sometimes we've had to fight
> GCC not to turn that into a division.
>
> But yes, I suppose we can put a limit on how many periods we can lag
> before just giving up.
OK.
> > So, I tend to think that we might want to play safe and put some higher
> > minimum value for dl_runtime (it's currently at 1ULL << DL_SCALE).
> > Guess the problem is to pick a reasonable value, though. Maybe link it
> > someway to HZ? Then we might add a sysctl (or similar) thing with which
> > knowledgeable users can do whatever they think their platform/config can
> > support?
>
> Yes, a HZ related limit sounds like something we'd want. But if we're
> going to do a minimum sysctl, we should also consider adding a maximum,
> if you set a massive period/deadline, you can, even with a relatively
> low u, incur significant delays.
>
> And do we want to put the limit on runtime or on period ?
>
> That is, something like:
>
> TICK_NSEC/2 < period < 10*TICK_NSEC
>
> and/or
>
> TICK_NSEC/2 < runtime < 10*TICK_NSEC
>
> Hmm, for HZ=1000 that ends up with a max period of 10ms, that's far too
> low, 24Hz needs ~41ms. We can of course also limit the runtime by
> capping u for users (as we should anyway).
I also thought of TICK_NSEC/2 as a reasonably safe lower limit, that
will implicitly limit period as well since
runtime <= deadline <= period
Not sure about the upper limit, though. Lower limit is something related
to the inherent granularity of the platform/config, upper limit is more
to do with highest prio stuff with huge period delaying everything else;
doesn't seem to be related to HZ?
Maybe we could just pick something that seems reasonably big to handle
SCHED_DEADLINE users needs and not too big to jeopardize everyone else,
say 0.5s?
next prev parent reply other threads:[~2018-10-18 10:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 7:31 INFO: rcu detected stall in do_idle syzbot
2018-10-16 13:24 ` Thomas Gleixner
2018-10-16 14:03 ` Peter Zijlstra
2018-10-16 14:41 ` Juri Lelli
2018-10-16 14:45 ` Thomas Gleixner
2018-10-16 15:36 ` Juri Lelli
2018-10-18 8:28 ` Juri Lelli
2018-10-18 9:48 ` Peter Zijlstra
2018-10-18 10:10 ` Juri Lelli [this message]
2018-10-18 10:38 ` luca abeni
2018-10-18 10:33 ` luca abeni
2018-10-19 13:14 ` Peter Zijlstra
2018-10-18 10:23 ` luca abeni
2018-10-18 10:47 ` Juri Lelli
2018-10-18 11:08 ` luca abeni
2018-10-18 12:21 ` Juri Lelli
2018-10-18 12:36 ` luca abeni
2018-10-19 11:39 ` Peter Zijlstra
2018-10-19 20:50 ` luca abeni
2018-10-24 12:03 ` Juri Lelli
2018-10-27 11:16 ` Dmitry Vyukov
2018-10-28 8:33 ` Juri Lelli
2018-10-30 10:45 ` Peter Zijlstra
2018-10-30 11:08 ` luca abeni
2018-10-31 16:18 ` Daniel Bristot de Oliveira
2018-10-31 16:40 ` Juri Lelli
2018-10-31 17:39 ` Peter Zijlstra
2018-10-31 17:58 ` Daniel Bristot de Oliveira
2018-11-01 5:55 ` Juri Lelli
2018-11-02 10:00 ` Daniel Bristot de Oliveira
2018-11-05 10:55 ` Juri Lelli
2018-11-07 10:12 ` Daniel Bristot de Oliveira
2018-10-31 17:38 ` Peter Zijlstra
2018-10-30 11:12 ` Juri Lelli
2018-11-06 11:44 ` Juri Lelli
2021-10-27 0:59 Hao Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018101008.GB21611@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=claudio@evidence.eu.com \
--cc=henrik@austad.us \
--cc=hpa@zytor.com \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@redhat.com \
--cc=nstange@suse.de \
--cc=peterz@infradead.org \
--cc=syzbot+385468161961cee80c31@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=tommaso.cucinotta@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).