From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471A4C5ACCC for ; Thu, 18 Oct 2018 13:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 177172098A for ; Thu, 18 Oct 2018 13:34:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 177172098A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728100AbeJRVfo (ORCPT ); Thu, 18 Oct 2018 17:35:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48018 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727199AbeJRVfo (ORCPT ); Thu, 18 Oct 2018 17:35:44 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6526C80F7B; Thu, 18 Oct 2018 13:34:40 +0000 (UTC) Received: from treble (ovpn-123-182.rdu2.redhat.com [10.10.123.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9E1455B6AD; Thu, 18 Oct 2018 13:34:32 +0000 (UTC) Date: Thu, 18 Oct 2018 08:34:25 -0500 From: Josh Poimboeuf To: Petr Mladek Cc: Jiri Kosina , Miroslav Benes , Jason Baron , Joe Lawrence , Evgenii Shatokhin , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 00/12] livepatch: Atomic replace feature Message-ID: <20181018133425.o3ykjjuqede3mmht@treble> References: <20181015123713.25868-1-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181015123713.25868-1-pmladek@suse.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 18 Oct 2018 13:34:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 15, 2018 at 02:37:01PM +0200, Petr Mladek wrote: > The atomic replace allows to create cumulative patches. They > are useful when you maintain many livepatches and want to remove > one that is lower on the stack. In addition it is very useful when > more patches touch the same function and there are dependencies > between them. > > Now, the question is if 13 is a lucky number. I hope so > and that this version might get merged. Any feedback? > > Not only from Mirek, please ;-) > > > Changes against v12: > > + Finish freeing the patch using workqueues to prevent > deadlock against kobject code. > > + Check for valid pointers when initializing the dynamic > lists objects and functions. > > + Mark klp_free_objects_dynamic() static. > > + Improved documentation and fixed typos Other than the few comments I made, this is looking good to me. I'm optimistic about v14. It's probably best to not merge a v13 anyway. ;-) Thanks a lot for sticking with it. -- Josh