From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E142C5ACCC for ; Thu, 18 Oct 2018 14:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D23CF2098A for ; Thu, 18 Oct 2018 14:59:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D23CF2098A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codemonkey.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728751AbeJRXAu (ORCPT ); Thu, 18 Oct 2018 19:00:50 -0400 Received: from scorn.kernelslacker.org ([45.56.101.199]:49624 "EHLO scorn.kernelslacker.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727370AbeJRXAt (ORCPT ); Thu, 18 Oct 2018 19:00:49 -0400 Received: from [2601:196:4600:5b90:ae9e:17ff:feb7:72ca] (helo=wopr.kernelslacker.org) by scorn.kernelslacker.org with esmtp (Exim 4.89) (envelope-from ) id 1gD9lj-0000PK-7g; Thu, 18 Oct 2018 10:59:23 -0400 Received: by wopr.kernelslacker.org (Postfix, from userid 1026) id DF910560296; Thu, 18 Oct 2018 10:59:22 -0400 (EDT) Date: Thu, 18 Oct 2018 10:59:22 -0400 From: Dave Jones To: Meelis Roos Cc: Cong Wang , LKML , Linux Kernel Network Developers Subject: Re: netconsole warning in 4.19.0-rc7 Message-ID: <20181018145922.ytqxvdihp3iqounl@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Meelis Roos , Cong Wang , LKML , Linux Kernel Network Developers References: <20181017034047.nrhstc3b4wzevnri@codemonkey.org.uk> <20181017035038.czaqown24rnjn2pw@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 17, 2018 at 09:22:13AM +0300, Meelis Roos wrote: > > I took another look at that error path. Turns out this is all we need I > > think.. > > With this patch applied on top of 4.19-rc8, I stll get the warning: > > [ 13.722919] WARNING: CPU: 0 PID: 0 at kernel/softirq.c:168 __local_bh_enable_ip+0x2e/0x44 It's going to be a couple days before I get chance to get back to this. Did the previous patch in this thread (without the _bh) fare any better? Dave