From: Bjorn Helgaas <helgaas@kernel.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: pcie: remove redundant 'default n' from Kconfig
Date: Thu, 18 Oct 2018 14:09:26 -0500 [thread overview]
Message-ID: <20181018190926.GJ5906@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20181016143814eucas1p21b1f3099131fc3f4263947932195299e~eHZ_4THEH2088320883eucas1p2s@eucas1p2.samsung.com>
On Tue, Oct 16, 2018 at 04:38:13PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Applied to pci/misc for v4.20, thanks!
> ---
> drivers/pci/pcie/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> Index: b/drivers/pci/pcie/Kconfig
> ===================================================================
> --- a/drivers/pci/pcie/Kconfig 2018-10-09 15:58:49.831123212 +0200
> +++ b/drivers/pci/pcie/Kconfig 2018-10-16 16:36:32.419732670 +0200
> @@ -36,7 +36,6 @@ config PCIEAER
> config PCIEAER_INJECT
> tristate "PCI Express error injection support"
> depends on PCIEAER && DYNAMIC_FTRACE_WITH_REGS
> - default n
> help
> This enables PCI Express Root Port Advanced Error Reporting
> (AER) software error injector.
> @@ -84,7 +83,6 @@ config PCIEASPM
> config PCIEASPM_DEBUG
> bool "Debug PCI Express ASPM"
> depends on PCIEASPM
> - default n
> help
> This enables PCI Express ASPM debug support. It will add per-device
> interface to control ASPM.
> @@ -129,7 +127,6 @@ config PCIE_PME
> config PCIE_DPC
> bool "PCI Express Downstream Port Containment support"
> depends on PCIEPORTBUS && PCIEAER
> - default n
> help
> This enables PCI Express Downstream Port Containment (DPC)
> driver support. DPC events from Root and Downstream ports
> @@ -139,7 +136,6 @@ config PCIE_DPC
>
> config PCIE_PTM
> bool "PCI Express Precision Time Measurement support"
> - default n
> depends on PCIEPORTBUS
> help
> This enables PCI Express Precision Time Measurement (PTM)
prev parent reply other threads:[~2018-10-18 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181016143814eucas1p21b1f3099131fc3f4263947932195299e@eucas1p2.samsung.com>
2018-10-16 14:38 ` [PATCH] PCI: pcie: remove redundant 'default n' from Kconfig Bartlomiej Zolnierkiewicz
2018-10-18 19:09 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181018190926.GJ5906@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).