From: Lars Poeschel <poeschel@lemonage.de>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: devicetree@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:NFC SUBSYSTEM" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] nfc: pn533: add UART phy driver
Date: Fri, 19 Oct 2018 10:57:28 +0200 [thread overview]
Message-ID: <20181019085728.GA26696@lem-wkst-02.lemonage> (raw)
In-Reply-To: <6CB47B97-F58D-4162-98C1-8C8C88CE2914@holtmann.org>
On Thu, Oct 18, 2018 at 05:00:28PM +0200, Marcel Holtmann wrote:
> Hi Lars,
>
> > This adds the UART phy interface for the pn533 driver.
> > The pn533 driver can be used through UART interface this way.
> > It is implemented as a serdev device.
> >
> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> > ---
> > Changes in v2:
> > - switched from tty line discipline to serdev, resulting in many
> > simplifications
> > - SPDX License Identifier
> >
> > drivers/nfc/pn533/Kconfig | 10 ++
> > drivers/nfc/pn533/Makefile | 2 +
> > drivers/nfc/pn533/pn533.h | 8 ++
> > drivers/nfc/pn533/uart.c | 283 +++++++++++++++++++++++++++++++++++++
> > 4 files changed, 303 insertions(+)
> > create mode 100644 drivers/nfc/pn533/uart.c
> >
> > diff --git a/drivers/nfc/pn533/Kconfig b/drivers/nfc/pn533/Kconfig
> > index d94122dd30e4..da3ea2dbaa8a 100644
> > --- a/drivers/nfc/pn533/Kconfig
> > +++ b/drivers/nfc/pn533/Kconfig
> > @@ -25,3 +25,13 @@ config NFC_PN533_I2C
> >
> > If you choose to build a module, it'll be called pn533_i2c.
> > Say N if unsure.
> > +
> > +config NFC_PN532_UART
> > + tristate "NFC PN532 device support (UART)”
>
> you are missing the "depends on SERIAL_DEV_BUS” here.
Yes, absolutely right. I missed that. I will post a follow-up.
BTW a question:
Only enabling SERIAL_DEV_BUS did not suffice for me. I also had to
enable SERIAL_DEV_CTRL_TTYPORT, otherwise the probe of the driver was
not called. This seems a bit odd to me. This option seems unrelated, but
without it, it did not work.
Should I better depend on SERIAL_DEV_CTRL_TTYPORT then ?
Thanks,
Lars
next prev parent reply other threads:[~2018-10-19 8:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 14:42 [PATCH v2 1/4] nfc: pn533: add UART phy driver Lars Poeschel
2018-10-18 14:42 ` [PATCH v2 2/4] nfc: pn532_uart: Add NXP PN532 to devicetree docs Lars Poeschel
2018-10-18 15:03 ` Marcel Holtmann
2018-10-18 20:41 ` Rob Herring
2018-10-19 9:12 ` Lars Poeschel
2018-10-18 14:42 ` [PATCH v2 3/4] nfc: pn533: Add autopoll capability Lars Poeschel
2018-10-18 14:42 ` [PATCH v2 4/4] nfc: pn532_uart: Make use of pn532 autopoll Lars Poeschel
2018-10-18 15:00 ` [PATCH v2 1/4] nfc: pn533: add UART phy driver Marcel Holtmann
2018-10-19 8:57 ` Lars Poeschel [this message]
2018-10-20 9:27 ` Johan Hovold
2018-10-25 13:28 ` Lars Poeschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019085728.GA26696@lem-wkst-02.lemonage \
--to=poeschel@lemonage.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).