From: Barret Rhoden <brho@google.com>
To: David Hildenbrand <david@redhat.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: "KVM list" <kvm@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Zhang, Yu C" <yu.c.zhang@intel.com>,
"Pankaj Gupta" <pagupta@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Christoph Hellwig" <hch@lst.de>, "Linux MM" <linux-mm@kvack.org>,
rkrcmar@redhat.com, "Jérôme Glisse" <jglisse@redhat.com>,
"Zhang, Yi Z" <yi.z.zhang@intel.com>
Subject: Re: [PATCH V5 4/4] kvm: add a check if pfn is from NVDIMM pmem.
Date: Fri, 19 Oct 2018 12:33:48 -0400 [thread overview]
Message-ID: <20181019123348.04ee7dd8@gnomeregan.cam.corp.google.com> (raw)
In-Reply-To: <159bb198-a4a1-0fee-bf57-24c3c28788bd@redhat.com>
On 2018-09-21 at 21:29 David Hildenbrand <david@redhat.com> wrote:
> On 21/09/2018 20:17, Dan Williams wrote:
> > On Fri, Sep 21, 2018 at 7:24 AM David Hildenbrand <david@redhat.com> wrote:
> > [..]
> >>> Remove the PageReserved flag sounds more reasonable.
> >>> And Could we still have a flag to identify it is a device private memory, or
> >>> where these pages coming from?
> >>
> >> We could use a page type for that or what you proposed. (as I said, we
> >> might have to change hibernation code to skip the pages once we drop the
> >> reserved flag).
> >
> > I think it would be reasonable to reject all ZONE_DEVICE pages in
> > saveable_page().
> >
>
> Indeed, that sounds like the easiest solution - guess that answer was
> too easy for me to figure out :) .
>
Just to follow-up, is the plan to clear PageReserved for nvdimm pages
instead of the approach taken in this patch set? Or should we special
case nvdimm/dax pages in kvm_is_reserved_pfn()?
Thanks,
Barret
next prev parent reply other threads:[~2018-10-19 16:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 18:03 [PATCH V5 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-09-07 17:04 ` Ahmed S. Darwish
2018-09-18 14:31 ` Yi Zhang
2018-09-07 18:03 ` [PATCH V5 1/4] kvm: remove redundant reserved page check Zhang Yi
2018-10-24 14:32 ` Yi Zhang
2018-09-07 18:03 ` [PATCH V5 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-09-07 18:03 ` [PATCH V5 3/4] mm: add a function to differentiate the pages is from DAX device memory Zhang Yi
2018-09-07 18:04 ` [PATCH V5 4/4] kvm: add a check if pfn is from NVDIMM pmem Zhang Yi
2018-09-19 2:53 ` Dan Williams
2018-09-19 7:20 ` David Hildenbrand
2018-09-20 22:49 ` Yi Zhang
2018-09-20 21:19 ` Dan Williams
2018-09-21 22:47 ` Yi Zhang
2018-09-21 14:23 ` David Hildenbrand
2018-09-21 18:17 ` Dan Williams
2018-09-21 19:29 ` David Hildenbrand
2018-10-19 16:33 ` Barret Rhoden [this message]
2018-10-22 8:47 ` Yi Zhang
2018-09-19 10:55 ` [PATCH V5 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Yi Zhang
2018-09-19 2:43 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181019123348.04ee7dd8@gnomeregan.cam.corp.google.com \
--to=brho@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yi.z.zhang@intel.com \
--cc=yu.c.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).