From: kbuild test robot <lkp@intel.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: kbuild-all@01.org, Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"Manoj N. Kumar" <manoj@linux.vnet.ibm.com>,
"Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>,
Uma Krishnan <ukrishn@linux.vnet.ibm.com>,
Bradley Grove <linuxdrivers@attotech.com>,
Don Brace <don.brace@microsemi.com>,
Brian King <brking@us.ibm.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, esc.storagedev@microsemi.com,
Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template
Date: Sat, 20 Oct 2018 12:52:53 +0800 [thread overview]
Message-ID: <201810201235.OQ2KlUKj%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181019175714.444-1-natechancellor@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2844 bytes --]
Hi Nathan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.19-rc8 next-20181019]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Nathan-Chancellor/scsi-ata-Use-unsigned-int-for-cmd-s-type-in-ioctls-in-scsi_host_template/20181020-120416
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
>> drivers/scsi//cxlflash/main.c:3170:11: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.ioctl = cxlflash_ioctl,
^~~~~~~~~~~~~~
drivers/scsi//cxlflash/main.c:3170:11: note: (near initialization for 'driver_template.ioctl')
cc1: some warnings being treated as errors
--
>> drivers/scsi//cxlflash/superpipe.c:2099:5: error: conflicting types for 'cxlflash_ioctl'
int cxlflash_ioctl(struct scsi_device *sdev, unsigned int cmd, void __user *arg)
^~~~~~~~~~~~~~
In file included from drivers/scsi//cxlflash/superpipe.c:29:0:
drivers/scsi//cxlflash/common.h:337:5: note: previous declaration of 'cxlflash_ioctl' was here
int cxlflash_ioctl(struct scsi_device *sdev, int cmd, void __user *arg);
^~~~~~~~~~~~~~
vim +/cxlflash_ioctl +2099 drivers/scsi//cxlflash/superpipe.c
2082
2083 /**
2084 * cxlflash_ioctl() - IOCTL handler for driver
2085 * @sdev: SCSI device associated with LUN.
2086 * @cmd: IOCTL command.
2087 * @arg: Userspace ioctl data structure.
2088 *
2089 * A read/write semaphore is used to implement a 'drain' of currently
2090 * running ioctls. The read semaphore is taken at the beginning of each
2091 * ioctl thread and released upon concluding execution. Additionally the
2092 * semaphore should be released and then reacquired in any ioctl execution
2093 * path which will wait for an event to occur that is outside the scope of
2094 * the ioctl (i.e. an adapter reset). To drain the ioctls currently running,
2095 * a thread simply needs to acquire the write semaphore.
2096 *
2097 * Return: 0 on success, -errno on failure
2098 */
> 2099 int cxlflash_ioctl(struct scsi_device *sdev, unsigned int cmd, void __user *arg)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58594 bytes --]
next prev parent reply other threads:[~2018-10-20 4:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 17:57 [PATCH] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template Nathan Chancellor
2018-10-19 19:38 ` Bart Van Assche
2018-10-20 4:52 ` kbuild test robot [this message]
2018-10-20 5:01 ` [PATCH v2] " Nathan Chancellor
2018-12-17 17:31 ` Nathan Chancellor
2019-01-14 4:42 ` [PATCH v3] " Nathan Chancellor
2019-01-14 4:54 ` Bart Van Assche
2019-01-14 4:57 ` Nathan Chancellor
2019-01-26 7:52 ` [PATCH v4] " Nathan Chancellor
2019-01-26 9:19 ` Nick Desaulniers
2019-01-28 16:16 ` Don.Brace
2019-01-28 16:17 ` Nathan Chancellor
2019-02-05 18:42 ` Grove, Bradley
2019-02-07 10:52 ` Marc Gonzalez
2019-02-07 16:07 ` [PATCH v5] " Nathan Chancellor
2019-02-07 19:17 ` Nick Desaulniers
2019-02-08 8:05 ` Christoph Hellwig
2019-02-08 16:00 ` Nathan Chancellor
2019-02-08 22:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201810201235.OQ2KlUKj%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=aacraid@microsemi.com \
--cc=axboe@kernel.dk \
--cc=brking@us.ibm.com \
--cc=bvanassche@acm.org \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kbuild-all@01.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxdrivers@attotech.com \
--cc=manoj@linux.vnet.ibm.com \
--cc=martin.petersen@oracle.com \
--cc=mrochs@linux.vnet.ibm.com \
--cc=natechancellor@gmail.com \
--cc=ukrishn@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).