From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
davidtgoldblatt@gmail.com, andrea.parri@amarulasolutions.com,
will.deacon@arm.com, peterz@infradead.org, boqun.feng@gmail.com,
npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk,
luc.maranget@inria.fr, akiyks@gmail.com, dlustig@nvidia.com
Subject: Re: Interrupts, smp_load_acquire(), smp_store_release(), etc.
Date: Sat, 20 Oct 2018 14:04:13 -0700 [thread overview]
Message-ID: <20181020210413.GB2674@linux.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1810201612530.28059-100000@netrider.rowland.org>
On Sat, Oct 20, 2018 at 04:18:37PM -0400, Alan Stern wrote:
> On Sat, 20 Oct 2018, Paul E. McKenney wrote:
>
> > The second (informal) litmus test has a more interesting Linux-kernel
> > counterpart:
> >
> > void t1_interrupt(void)
> > {
> > r0 = READ_ONCE(y);
> > smp_store_release(&x, 1);
> > }
> >
> > void t1(void)
> > {
> > smp_store_release(&y, 1);
> > }
> >
> > void t2(void)
> > {
> > r1 = smp_load_acquire(&x);
> > r2 = smp_load_acquire(&y);
> > }
> >
> > On store-reordering architectures that implement smp_store_release()
> > as a memory-barrier instruction followed by a store, the interrupt could
> > arrive betweentimes in t1(), so that there would be no ordering between
> > t1_interrupt()'s store to x and t1()'s store to y. This could (again,
> > in paranoid theory) result in the outcome r0==0 && r1==0 && r2==1.
>
> This is disconcerting only if we assume that t1_interrupt() has to be
> executed by the same CPU as t1(). If the interrupt could be fielded by
> a different CPU then the paranoid outcome is perfectly understandable,
> even in an SC context.
>
> So the question really should be limited to situations where a handler
> is forced to execute in the context of a particular thread. While
> POSIX does allow such restrictions for user programs, I'm not aware of
> any similar mechanism in the kernel.
Good point, and I was in fact assuming that t1() and t1_interrupt()
were executing on the same CPU.
This sort of thing happens naturally in the kernel when both t1()
and t1_interrupt() are accessing per-CPU variables.
Thanx, Paul
next prev parent reply other threads:[~2018-10-20 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-20 16:10 Interrupts, smp_load_acquire(), smp_store_release(), etc Paul E. McKenney
2018-10-20 20:18 ` Alan Stern
2018-10-20 21:04 ` Paul E. McKenney [this message]
2018-10-22 17:30 ` Eric W. Biederman
2018-10-20 20:22 ` Andrea Parri
2018-10-20 21:06 ` Paul E. McKenney
2018-10-21 14:52 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181020210413.GB2674@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=akiyks@gmail.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=boqun.feng@gmail.com \
--cc=davidtgoldblatt@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).