From: Jonathan Cameron <jic23@kernel.org>
To: Song Qiang <songqiang1304521@gmail.com>
Cc: Himanshu Jha <himanshujha199640@gmail.com>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
robh+dt@kernel.org, mark.rutland@arm.com,
preid@electromag.com.au, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] iio: magnetometer: Add driver support for PNI RM3100
Date: Sun, 21 Oct 2018 15:08:57 +0100 [thread overview]
Message-ID: <20181021150857.4f9c2244@archlinux> (raw)
In-Reply-To: <ce65b203-2a44-08e4-bdd0-f3c8df48e2f1@gmail.com>
On Wed, 17 Oct 2018 16:00:02 +0800
Song Qiang <songqiang1304521@gmail.com> wrote:
> On 2018/10/12 下午8:53, Himanshu Jha wrote:
> > Hi Qiang,
> >
> > On Fri, Oct 12, 2018 at 04:36:01PM +0800, Song Qiang wrote:
> >>
> >> On 2018年10月12日 15:35, Song Qiang wrote:
> >>> PNI RM3100 is a high resolution, large signal immunity magnetometer,
> >>> composed of 3 single sensors and a processing chip with a MagI2C
> >>> interface.
> >>>
> >> ...
> >>> +static irqreturn_t rm3100_trigger_handler(int irq, void *p)
> >>> +{
> >>> + struct iio_poll_func *pf = p;
> >>> + struct iio_dev *indio_dev = pf->indio_dev;
> >>> + unsigned long scan_mask = *indio_dev->active_scan_mask;
> >>> + unsigned int mask_len = indio_dev->masklength;
> >>> + struct rm3100_data *data = iio_priv(indio_dev);
> >>> + struct regmap *regmap = data->regmap;
> >>> + int ret, i, bit;
> >>> +
> >>> + mutex_lock(&data->lock);
> >>> + switch (scan_mask) {
> >>> + case BIT(0) | BIT(1) | BIT(2):
> >>> + ret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 9);
> >>> + mutex_unlock(&data->lock);
> >>> + if (ret < 0)
> >>> + goto done;
> >>> + break;
> >>> + case BIT(0) | BIT(1):
> >>> + ret = regmap_bulk_read(regmap, RM3100_REG_MX2, data->buffer, 6);
> >>> + mutex_unlock(&data->lock);
> >>> + if (ret < 0)
> >>> + goto done;
> >>> + break;
> >>> + case BIT(1) | BIT(2):
> >>> + ret = regmap_bulk_read(regmap, RM3100_REG_MY2, data->buffer, 6);
> >>> + mutex_unlock(&data->lock);
> >>> + if (ret < 0)
> >>> + goto done;
> >>> + break;
> >> Hi Jonathan,
> >>
> >> I just noticed that these three breaks are not proper aligned.
> > Please send the new version of a patch as a *new* thread and don't
> > use `--in-reply-to` flag(if you're using) to chain into older versions
> > as whole thread of older discussion comes up and is often not required.
> >
> > The changelog gives enough info of what's new in the revised series.
> >
> >
> Hi Himanshu,
>
>
> Thanks for your advise.
>
> I did it because the following instruction tells me to, and I think it's
> also a very quick way of gathering
>
> all scattered messages. Both ways have their own advantages and
> disadvantages I think. :)
>
> <https://kernelnewbies.org/PatchPhilosophy> Section "Updating and
> resending patches".
That's a curious bit of advice. There are certainly a lot of maintainers
who would not want that. It never works with anything beyond trivial
and short patches (we have had patches going to v13 + and hundreds of
emails) - no email client handles that depth and complexity in
a coherent fashion. Replying to previous versions is one of those things
that makes sense until you hit the 'unusual cases' ;)
Oh well. I should probably propose a change to that Doc, but it make
take some time for me to get around to it.
Thanks,
Jonathan
>
>
> yours,
>
> Song Qiang
>
next prev parent reply other threads:[~2018-10-21 14:09 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 3:17 [PATCH 1/2] iio: magnetometer: Add DT support for PNI RM3100 Song Qiang
2018-09-25 3:17 ` [PATCH 2/2] iio: magnetometer: Add driver " Song Qiang
2018-09-25 13:30 ` Jonathan Cameron
2018-09-25 14:36 ` Phil Reid
2018-09-26 1:49 ` Song Qiang
2018-09-26 2:30 ` Phil Reid
2018-09-26 8:09 ` Song Qiang
2018-09-27 1:57 ` Phil Reid
2018-09-29 11:37 ` Jonathan Cameron
2018-09-26 1:33 ` Song Qiang
2018-09-29 11:45 ` Jonathan Cameron
2018-09-25 17:50 ` Himanshu Jha
2018-09-26 2:24 ` Song Qiang
2018-09-25 13:05 ` [PATCH 1/2] iio: magnetometer: Add DT " Jonathan Cameron
2018-10-02 14:38 ` [PATCH v3 0/3] Add support for PNI RM3100 magnetometer Song Qiang
2018-10-02 14:38 ` [PATCH v3 1/3] dt-bindings: Add PNI to the vendor prefixes Song Qiang
2018-10-02 14:38 ` [PATCH v3 2/3] dt-bindings: Add PNI RM3100 device tree binding Song Qiang
2018-10-07 15:18 ` Jonathan Cameron
2018-10-07 15:20 ` Jonathan Cameron
2018-10-02 14:38 ` [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100 Song Qiang
2018-10-03 1:42 ` Phil Reid
2018-10-07 15:07 ` Jonathan Cameron
2018-10-07 15:44 ` Jonathan Cameron
2018-10-11 4:35 ` Song Qiang
2018-10-13 9:24 ` Jonathan Cameron
2018-10-12 7:35 ` [PATCH v4 0/3] Add support for PNI RM3100 magnetometer Song Qiang
2018-10-12 7:35 ` [PATCH v4 1/3] dt-bindings: Add PNI to the vendor prefixes Song Qiang
2018-10-12 11:36 ` Rob Herring
2018-10-12 7:35 ` [PATCH v4 2/3] iio: magnetometer: Add DT support for PNI RM3100 Song Qiang
2018-10-12 11:37 ` Rob Herring
2018-10-12 7:35 ` [PATCH v4 3/3] iio: magnetometer: Add driver " Song Qiang
2018-10-12 8:36 ` Song Qiang
2018-10-12 12:53 ` Himanshu Jha
2018-10-17 8:00 ` Song Qiang
2018-10-21 14:08 ` Jonathan Cameron [this message]
2018-10-13 10:19 ` Jonathan Cameron
2018-10-18 8:24 ` Song Qiang
2018-10-21 14:14 ` Jonathan Cameron
2018-11-02 7:55 ` Song Qiang
2018-11-02 9:24 ` Jonathan Cameron
2018-11-05 0:39 ` Song Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181021150857.4f9c2244@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=himanshujha199640@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=songqiang1304521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).