From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4529EECDE44 for ; Sun, 21 Oct 2018 20:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 189E220652 for ; Sun, 21 Oct 2018 20:04:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 189E220652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728693AbeJVEUE (ORCPT ); Mon, 22 Oct 2018 00:20:04 -0400 Received: from sauhun.de ([88.99.104.3]:45732 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726209AbeJVEPu (ORCPT ); Mon, 22 Oct 2018 00:15:50 -0400 Received: from localhost (unknown [90.200.225.72]) by pokefinder.org (Postfix) with ESMTPSA id BEFA92E35C1; Sun, 21 Oct 2018 22:00:22 +0200 (CEST) From: Wolfram Sang To: linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 0/9] net: simplify getting .driver_data Date: Sun, 21 Oct 2018 22:00:11 +0200 Message-Id: <20181021200021.1693-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I got tired of fixing this in Renesas drivers manually, so I took the big hammer. Remove this cumbersome code pattern which got copy-pasted too much already: - struct platform_device *pdev = to_platform_device(dev); - struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); + struct ep93xx_keypad *keypad = dev_get_drvdata(dev); A branch, tested by buildbot, can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git coccinelle/get_drvdata I have been asked if it couldn't be done for dev_set_drvdata as well. I checked it and did not find one occasion where it could be simplified like this. Not much of a surprise because driver_data is usually set in probe() functions which access struct platform_device in many other ways. I am open for other comments, suggestions, too, of course. Here is the cocci-script I created: @@ struct device* d; identifier pdev; expression *ptr; @@ ( - struct platform_device *pdev = to_platform_device(d); | - struct platform_device *pdev; ... - pdev = to_platform_device(d); ) <... when != pdev - &pdev->dev + d ...> ptr = - platform_get_drvdata(pdev) + dev_get_drvdata(d) <... when != pdev - &pdev->dev + d ...> Kind regards, Wolfram Wolfram Sang (9): net: dsa: bcm_sf2: simplify getting .driver_data net: dsa: qca8k: simplify getting .driver_data net: ethernet: cadence: macb_main: simplify getting .driver_data net: ethernet: davicom: dm9000: simplify getting .driver_data net: ethernet: smsc: smc91x: simplify getting .driver_data net: ethernet: ti: cpsw: simplify getting .driver_data net: ethernet: ti: davinci_emac: simplify getting .driver_data net: ethernet: wiznet: w5300: simplify getting .driver_data net: phy: mdio-mux-bcm-iproc: simplify getting .driver_data drivers/net/dsa/bcm_sf2.c | 6 ++---- drivers/net/dsa/qca8k.c | 6 ++---- drivers/net/ethernet/cadence/macb_main.c | 6 ++---- drivers/net/ethernet/davicom/dm9000.c | 6 ++---- drivers/net/ethernet/smsc/smc91x.c | 3 +-- drivers/net/ethernet/ti/cpsw.c | 6 ++---- drivers/net/ethernet/ti/davinci_emac.c | 6 ++---- drivers/net/ethernet/wiznet/w5300.c | 6 ++---- drivers/net/phy/mdio-mux-bcm-iproc.c | 6 ++---- 9 files changed, 17 insertions(+), 34 deletions(-) -- 2.19.0