archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <>
	Wolfram Sang <>,
Subject: [PATCH 0/1] ptp: simplify getting .driver_data
Date: Sun, 21 Oct 2018 22:00:38 +0200	[thread overview]
Message-ID: <> (raw)

I got tired of fixing this in Renesas drivers manually, so I took the big
hammer. Remove this cumbersome code pattern which got copy-pasted too much

-	struct platform_device *pdev = to_platform_device(dev);
-	struct ep93xx_keypad *keypad = platform_get_drvdata(pdev);
+	struct ep93xx_keypad *keypad = dev_get_drvdata(dev);

A branch, tested by buildbot, can be found here:

git:// coccinelle/get_drvdata

I have been asked if it couldn't be done for dev_set_drvdata as well. I checked
it and did not find one occasion where it could be simplified like this. Not
much of a surprise because driver_data is usually set in probe() functions
which access struct platform_device in many other ways.

I am open for other comments, suggestions, too, of course.

Here is the cocci-script I created:

struct device* d;
identifier pdev;
expression *ptr;
-	struct platform_device *pdev = to_platform_device(d);
-	struct platform_device *pdev;
-	pdev = to_platform_device(d);
	<... when != pdev
-	&pdev->dev
+	d

	ptr =
-	platform_get_drvdata(pdev)
+	dev_get_drvdata(d)

	<... when != pdev
-	&pdev->dev
+	d

Kind regards,


Wolfram Sang (1):
  ptp: ptp_dte: simplify getting .driver_data

 drivers/ptp/ptp_dte.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)


             reply	other threads:[~2018-10-21 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-21 20:00 Wolfram Sang [this message]
2018-10-21 20:00 ` [PATCH 1/1] ptp: ptp_dte: " Wolfram Sang
2018-10-22 22:43   ` Richard Cochran
2018-10-23  2:49   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [PATCH 0/1] ptp: simplify getting .driver_data' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).