From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/5] pinctrl: intel: pinctrl-baytrail: simplify getting .driver_data
Date: Mon, 22 Oct 2018 00:19:51 +0300 [thread overview]
Message-ID: <20181021211951.GM10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181021200032.1833-2-wsa+renesas@sang-engineering.com>
On Sun, Oct 21, 2018 at 10:00:27PM +0200, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
Thanks!
I see only 3 out of 5 patches.
Since we are about to establish a separate tree as well as an additional record
in MAINTAINERS data base for Intel pinctrl driver, I ask you to resend only
Intel related stuff in a separate series.
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Build tested only. buildbot is happy.
>
> drivers/pinctrl/intel/pinctrl-baytrail.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index 6d1a43c0c251..a1c2548123a1 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -1838,8 +1838,7 @@ static int byt_pinctrl_probe(struct platform_device *pdev)
> #ifdef CONFIG_PM_SLEEP
> static int byt_gpio_suspend(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct byt_gpio *vg = platform_get_drvdata(pdev);
> + struct byt_gpio *vg = dev_get_drvdata(dev);
> int i;
>
> for (i = 0; i < vg->soc_data->npins; i++) {
> @@ -1867,8 +1866,7 @@ static int byt_gpio_suspend(struct device *dev)
>
> static int byt_gpio_resume(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct byt_gpio *vg = platform_get_drvdata(pdev);
> + struct byt_gpio *vg = dev_get_drvdata(dev);
> int i;
>
> for (i = 0; i < vg->soc_data->npins; i++) {
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-10-21 21:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 20:00 [PATCH 0/5] pinctrl: simplify getting .driver_data Wolfram Sang
2018-10-21 20:00 ` [PATCH 1/5] pinctrl: intel: pinctrl-baytrail: " Wolfram Sang
2018-10-21 21:19 ` Andy Shevchenko [this message]
2018-10-22 8:17 ` Mika Westerberg
2018-10-22 10:55 ` Andy Shevchenko
2018-10-30 13:22 ` Linus Walleij
2018-10-21 20:00 ` [PATCH 2/5] pinctrl: intel: pinctrl-cherryview: " Wolfram Sang
2018-10-22 8:17 ` Mika Westerberg
2018-10-21 20:00 ` [PATCH 3/5] pinctrl: intel: pinctrl-intel: " Wolfram Sang
2018-10-22 8:17 ` Mika Westerberg
2018-10-21 20:00 ` [PATCH 4/5] pinctrl: pinctrl-amd: " Wolfram Sang
2018-10-30 13:16 ` Linus Walleij
2018-10-21 20:00 ` [PATCH 5/5] pinctrl: pinctrl-at91-pio4: " Wolfram Sang
2018-10-24 11:15 ` Alexandre Belloni
2018-10-29 14:32 ` Ludovic Desroches
2018-10-30 13:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181021211951.GM10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).