From: Douglas Anderson <dianders@chromium.org> To: Sean Paul <seanpaul@chromium.org>, Thierry Reding <thierry.reding@gmail.com>, Sandeep Panda <spanda@codeaurora.org> Cc: linux-arm-msm@vger.kernel.org, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, jsanka@codeaurora.org, ryandcase@chromium.org, Douglas Anderson <dianders@chromium.org>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1 Date: Mon, 22 Oct 2018 13:46:38 -0700 [thread overview] Message-ID: <20181022204639.8558-5-dianders@chromium.org> (raw) In-Reply-To: <20181022204639.8558-1-dianders@chromium.org> As far as I can tell the panel that was added in commit da50bd4258db ("drm/panel: simple: Add Innolux TV123WAM panel driver support") wasn't actually an Innolux TV123WAM but was actually an Innolux P120ZDG-BF1. As far as I can tell the Innolux TV123WAM isn't a real panel and but it's a mosh between the TI TV123WAM and the Innolux P120ZDG-BF1. Let's unmosh. Here's my evidence: * Searching for TV123WAM on the Internet turns up a TI panel. While it's possible that an Innolux panel has the same model number as the TI Panel, it seems a little doubtful. Looking up the datasheet from the TI Panel shows that it's 1920 x 1280 and 259.2 mm x 172.8 mm. * As far as I know, the patch adding the Innolux Panel was supposed to be for the board that's sitting in front of me as I type this (support for that board is not yet upstream). On the back of that panel I see Innolux P120ZDZ-EZ1 rev B1. * Someone pointed me at a datasheet that's supposed to be for the panel in front of me (sorry, I can't share the datasheet). That datasheet has the string "p120zdg-bf1" * If I search for "P120ZDG-BF1" on the Internet I get hits for panels that are 2160x1440. They don't have datasheets, but the fact that the resolution matches is a good sign. In any case, let's update the name and also the physical size to match the correct panel. Fixes: da50bd4258db ("drm/panel: simple: Add Innolux TV123WAM panel driver support") Signed-off-by: Douglas Anderson <dianders@chromium.org> Cc: Sandeep Panda <spanda@codeaurora.org> --- drivers/gpu/drm/panel/panel-simple.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 937e97490c30..7ee1abc5d81b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1370,7 +1370,7 @@ static const struct panel_desc innolux_n156bge_l21 = { }, }; -static const struct drm_display_mode innolux_tv123wam_mode = { +static const struct drm_display_mode innolux_p120zdg_bf1_mode = { .clock = 206016, .hdisplay = 2160, .hsync_start = 2160 + 48, @@ -1384,13 +1384,13 @@ static const struct drm_display_mode innolux_tv123wam_mode = { .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, }; -static const struct panel_desc innolux_tv123wam = { - .modes = &innolux_tv123wam_mode, +static const struct panel_desc innolux_p120zdg_bf1 = { + .modes = &innolux_p120zdg_bf1_mode, .num_modes = 1, .bpc = 8, .size = { - .width = 259, - .height = 173, + .width = 254, + .height = 169, }, .delay = { .prepare = 200, @@ -2454,8 +2454,8 @@ static const struct of_device_id platform_of_match[] = { .compatible = "innolux,n156bge-l21", .data = &innolux_n156bge_l21, }, { - .compatible = "innolux,tv123wam", - .data = &innolux_tv123wam, + .compatible = "innolux,p120zdg-bf1", + .data = &innolux_p120zdg_bf1, }, { .compatible = "innolux,zj070na-01p", .data = &innolux_zj070na_01p, -- 2.19.1.568.g152ad8e336-goog
next prev parent reply other threads:[~2018-10-22 20:49 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-22 20:46 [PATCH 1/6] dt-bindings: drm/panel: simple: Add no-hpd property Douglas Anderson 2018-10-22 20:46 ` [PATCH 2/6] drm/panel: simple: Support panels with HPD where HPD isn't connected Douglas Anderson 2018-10-25 18:08 ` Sean Paul 2018-10-22 20:46 ` [PATCH 3/6] drm/panel: simple: Add "no-hpd" delay for Innolux TV123WAM Douglas Anderson 2018-10-22 20:46 ` [PATCH 4/6] drm/bridge: ti-sn65dsi86: Remove the mystery delay Douglas Anderson 2018-10-25 18:10 ` Sean Paul 2018-10-22 20:46 ` Douglas Anderson [this message] 2018-10-25 18:13 ` [PATCH 5/6] drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1 Sean Paul 2018-10-25 18:45 ` Doug Anderson 2018-10-25 19:25 ` Abhinav Kumar 2018-10-25 22:24 ` Doug Anderson 2018-10-26 14:38 ` Sean Paul 2018-10-22 20:46 ` [PATCH 6/6] dt-bindings: " Douglas Anderson 2018-10-25 18:15 ` Sean Paul 2018-10-25 19:49 ` Rob Herring 2018-10-25 18:06 ` [PATCH 1/6] dt-bindings: drm/panel: simple: Add no-hpd property Sean Paul 2018-10-25 19:28 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181022204639.8558-5-dianders@chromium.org \ --to=dianders@chromium.org \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=jsanka@codeaurora.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ryandcase@chromium.org \ --cc=seanpaul@chromium.org \ --cc=spanda@codeaurora.org \ --cc=thierry.reding@gmail.com \ --subject='Re: [PATCH 5/6] drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).