* [PATCH 0/1] rtc: simplify getting .driver_data
@ 2018-10-21 20:00 Wolfram Sang
2018-10-21 20:00 ` [PATCH 1/1] rtc: ds1685: " Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2018-10-21 20:00 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-renesas-soc, Wolfram Sang, linux-rtc
I got tired of fixing this in Renesas drivers manually, so I took the big
hammer. Remove this cumbersome code pattern which got copy-pasted too much
already:
- struct platform_device *pdev = to_platform_device(dev);
- struct ep93xx_keypad *keypad = platform_get_drvdata(pdev);
+ struct ep93xx_keypad *keypad = dev_get_drvdata(dev);
A branch, tested by buildbot, can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git coccinelle/get_drvdata
I have been asked if it couldn't be done for dev_set_drvdata as well. I checked
it and did not find one occasion where it could be simplified like this. Not
much of a surprise because driver_data is usually set in probe() functions
which access struct platform_device in many other ways.
I am open for other comments, suggestions, too, of course.
Here is the cocci-script I created:
@@
struct device* d;
identifier pdev;
expression *ptr;
@@
(
- struct platform_device *pdev = to_platform_device(d);
|
- struct platform_device *pdev;
...
- pdev = to_platform_device(d);
)
<... when != pdev
- &pdev->dev
+ d
...>
ptr =
- platform_get_drvdata(pdev)
+ dev_get_drvdata(d)
<... when != pdev
- &pdev->dev
+ d
...>
Kind regards,
Wolfram
Wolfram Sang (1):
rtc: ds1685: simplify getting .driver_data
drivers/rtc/rtc-ds1685.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
2.19.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] rtc: ds1685: simplify getting .driver_data
2018-10-21 20:00 [PATCH 0/1] rtc: simplify getting .driver_data Wolfram Sang
@ 2018-10-21 20:00 ` Wolfram Sang
2018-10-22 15:53 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2018-10-21 20:00 UTC (permalink / raw)
To: linux-kernel
Cc: linux-renesas-soc, Wolfram Sang, Joshua Kinard, Alessandro Zummo,
Alexandre Belloni, linux-rtc
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Build tested only. buildbot is happy.
drivers/rtc/rtc-ds1685.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
index b0723025ac31..2710f2594c42 100644
--- a/drivers/rtc/rtc-ds1685.c
+++ b/drivers/rtc/rtc-ds1685.c
@@ -778,8 +778,7 @@ static const char *ds1685_rtc_sqw_freq[16] = {
static int
ds1685_rtc_proc(struct device *dev, struct seq_file *seq)
{
- struct platform_device *pdev = to_platform_device(dev);
- struct ds1685_priv *rtc = platform_get_drvdata(pdev);
+ struct ds1685_priv *rtc = dev_get_drvdata(dev);
u8 ctrla, ctrlb, ctrlc, ctrld, ctrl4a, ctrl4b, ssn[8];
char *model;
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] rtc: ds1685: simplify getting .driver_data
2018-10-21 20:00 ` [PATCH 1/1] rtc: ds1685: " Wolfram Sang
@ 2018-10-22 15:53 ` Alexandre Belloni
2018-10-22 17:28 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2018-10-22 15:53 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Joshua Kinard, Alessandro Zummo,
linux-rtc
On 21/10/2018 22:00:41+0200, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Build tested only. buildbot is happy.
>
> drivers/rtc/rtc-ds1685.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] rtc: ds1685: simplify getting .driver_data
2018-10-22 15:53 ` Alexandre Belloni
@ 2018-10-22 17:28 ` Alexandre Belloni
2018-10-22 21:10 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2018-10-22 17:28 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, linux-renesas-soc, Joshua Kinard, Alessandro Zummo,
linux-rtc
On 22/10/2018 17:53:35+0200, Alexandre Belloni wrote:
> On 21/10/2018 22:00:41+0200, Wolfram Sang wrote:
> > We should get 'driver_data' from 'struct device' directly. Going via
> > platform_device is an unneeded step back and forth.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> >
> > Build tested only. buildbot is happy.
> >
> > drivers/rtc/rtc-ds1685.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> Applied, thanks.
>
By the way, is there any reason why this was not part of your patch back
in April? I had a deja vu feeling ;)
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] rtc: ds1685: simplify getting .driver_data
2018-10-22 17:28 ` Alexandre Belloni
@ 2018-10-22 21:10 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2018-10-22 21:10 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Wolfram Sang, linux-kernel, linux-renesas-soc, Joshua Kinard,
Alessandro Zummo, linux-rtc
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
> By the way, is there any reason why this was not part of your patch back
> in April? I had a deja vu feeling ;)
I haven't checked but I guess the driver looked different back then. I
didn't update the rule, so it should have matched back then, too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-22 21:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-21 20:00 [PATCH 0/1] rtc: simplify getting .driver_data Wolfram Sang
2018-10-21 20:00 ` [PATCH 1/1] rtc: ds1685: " Wolfram Sang
2018-10-22 15:53 ` Alexandre Belloni
2018-10-22 17:28 ` Alexandre Belloni
2018-10-22 21:10 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).