* [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup support
2018-10-23 5:30 [PATCH V1 0/4] ARM: dts: imx: Add flexcan stop mode wakeup Joakim Zhang
@ 2018-10-23 5:30 ` Joakim Zhang
2018-11-04 7:39 ` Shawn Guo
2018-10-23 5:30 ` [PATCH V1 2/4] ARM: dts: imx6qdl: " Joakim Zhang
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Joakim Zhang @ 2018-10-23 5:30 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: kernel, Fabio Estevam, dl-linux-imx, robh+dt, linux-arm-kernel,
devicetree, linux-kernel, A.s. Dong, Joakim Zhang
From: Dong Aisheng <aisheng.dong@nxp.com>
Add stop-mode property which is required by stop mode wakeup
feature.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
arch/arm/boot/dts/imx6sx.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 844caa39364f..3f459d6da7fc 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -448,6 +448,7 @@
clocks = <&clks IMX6SX_CLK_CAN1_IPG>,
<&clks IMX6SX_CLK_CAN1_SERIAL>;
clock-names = "ipg", "per";
+ stop-mode = <&gpr 0x10 1 0x10 17>;
status = "disabled";
};
@@ -458,6 +459,7 @@
clocks = <&clks IMX6SX_CLK_CAN2_IPG>,
<&clks IMX6SX_CLK_CAN2_SERIAL>;
clock-names = "ipg", "per";
+ stop-mode = <&gpr 0x10 2 0x10 18>;
status = "disabled";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup support
2018-10-23 5:30 ` [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup support Joakim Zhang
@ 2018-11-04 7:39 ` Shawn Guo
2018-11-12 1:58 ` Joakim Zhang
0 siblings, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2018-11-04 7:39 UTC (permalink / raw)
To: Joakim Zhang
Cc: s.hauer, kernel, Fabio Estevam, dl-linux-imx, robh+dt,
linux-arm-kernel, devicetree, linux-kernel, A.s. Dong
On Tue, Oct 23, 2018 at 05:30:44AM +0000, Joakim Zhang wrote:
> From: Dong Aisheng <aisheng.dong@nxp.com>
>
> Add stop-mode property which is required by stop mode wakeup
> feature.
>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> ---
> arch/arm/boot/dts/imx6sx.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 844caa39364f..3f459d6da7fc 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -448,6 +448,7 @@
> clocks = <&clks IMX6SX_CLK_CAN1_IPG>,
> <&clks IMX6SX_CLK_CAN1_SERIAL>;
> clock-names = "ipg", "per";
> + stop-mode = <&gpr 0x10 1 0x10 17>;
Is it supported by upstream? I cannot find this property in ether flexcan
bindings doc or kernel driver.
Shawn
> status = "disabled";
> };
>
> @@ -458,6 +459,7 @@
> clocks = <&clks IMX6SX_CLK_CAN2_IPG>,
> <&clks IMX6SX_CLK_CAN2_SERIAL>;
> clock-names = "ipg", "per";
> + stop-mode = <&gpr 0x10 2 0x10 18>;
> status = "disabled";
> };
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup support
2018-11-04 7:39 ` Shawn Guo
@ 2018-11-12 1:58 ` Joakim Zhang
0 siblings, 0 replies; 7+ messages in thread
From: Joakim Zhang @ 2018-11-12 1:58 UTC (permalink / raw)
To: Shawn Guo
Cc: s.hauer, kernel, Fabio Estevam, dl-linux-imx, robh+dt,
linux-arm-kernel, devicetree, linux-kernel, A.s. Dong
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: 2018年11月4日 15:40
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: s.hauer@pengutronix.de; kernel@pengutronix.de; Fabio Estevam
> <fabio.estevam@nxp.com>; dl-linux-imx <linux-imx@nxp.com>;
> robh+dt@kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; A.s. Dong
> <aisheng.dong@nxp.com>
> Subject: Re: [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup
> support
>
> On Tue, Oct 23, 2018 at 05:30:44AM +0000, Joakim Zhang wrote:
> > From: Dong Aisheng <aisheng.dong@nxp.com>
> >
> > Add stop-mode property which is required by stop mode wakeup feature.
> >
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > ---
> > arch/arm/boot/dts/imx6sx.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6sx.dtsi
> > b/arch/arm/boot/dts/imx6sx.dtsi index 844caa39364f..3f459d6da7fc
> > 100644
> > --- a/arch/arm/boot/dts/imx6sx.dtsi
> > +++ b/arch/arm/boot/dts/imx6sx.dtsi
> > @@ -448,6 +448,7 @@
> > clocks = <&clks IMX6SX_CLK_CAN1_IPG>,
> > <&clks IMX6SX_CLK_CAN1_SERIAL>;
> > clock-names = "ipg", "per";
> > + stop-mode = <&gpr 0x10 1 0x10 17>;
>
> Is it supported by upstream? I cannot find this property in ether flexcan
> bindings doc or kernel driver.
>
> Shawn
Hi Shawn,
This property has been reviewed by maintainer in flexcan bindings and kernel driver has sent to review.
Best Regards,
Joakim Zhang
> > status = "disabled";
> > };
> >
> > @@ -458,6 +459,7 @@
> > clocks = <&clks IMX6SX_CLK_CAN2_IPG>,
> > <&clks IMX6SX_CLK_CAN2_SERIAL>;
> > clock-names = "ipg", "per";
> > + stop-mode = <&gpr 0x10 2 0x10 18>;
> > status = "disabled";
> > };
> >
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH V1 2/4] ARM: dts: imx6qdl: Add flexcan stop mode wakeup support
2018-10-23 5:30 [PATCH V1 0/4] ARM: dts: imx: Add flexcan stop mode wakeup Joakim Zhang
2018-10-23 5:30 ` [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup support Joakim Zhang
@ 2018-10-23 5:30 ` Joakim Zhang
2018-10-23 5:31 ` [PATCH V1 3/4] ARM: dts: imx6ul: " Joakim Zhang
2018-10-23 5:31 ` [PATCH V1 4/4] ARM: dts: imx7s: " Joakim Zhang
3 siblings, 0 replies; 7+ messages in thread
From: Joakim Zhang @ 2018-10-23 5:30 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: kernel, Fabio Estevam, dl-linux-imx, robh+dt, linux-arm-kernel,
devicetree, linux-kernel, A.s. Dong, Joakim Zhang
From: Dong Aisheng <aisheng.dong@nxp.com>
Add stop-mode property which is required by stop mode wakeup
feature.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
arch/arm/boot/dts/imx6qdl.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 61d2d26afbf4..eb84ebcbe358 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -548,6 +548,7 @@
clocks = <&clks IMX6QDL_CLK_CAN1_IPG>,
<&clks IMX6QDL_CLK_CAN1_SERIAL>;
clock-names = "ipg", "per";
+ stop-mode = <&gpr 0x34 28 0x10 17>;
status = "disabled";
};
@@ -558,6 +559,7 @@
clocks = <&clks IMX6QDL_CLK_CAN2_IPG>,
<&clks IMX6QDL_CLK_CAN2_SERIAL>;
clock-names = "ipg", "per";
+ stop-mode = <&gpr 0x34 29 0x10 18>;
status = "disabled";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V1 3/4] ARM: dts: imx6ul: Add flexcan stop mode wakeup support
2018-10-23 5:30 [PATCH V1 0/4] ARM: dts: imx: Add flexcan stop mode wakeup Joakim Zhang
2018-10-23 5:30 ` [PATCH V1 1/4] ARM: dts: imx6sx: Add flexcan stop mode wakeup support Joakim Zhang
2018-10-23 5:30 ` [PATCH V1 2/4] ARM: dts: imx6qdl: " Joakim Zhang
@ 2018-10-23 5:31 ` Joakim Zhang
2018-10-23 5:31 ` [PATCH V1 4/4] ARM: dts: imx7s: " Joakim Zhang
3 siblings, 0 replies; 7+ messages in thread
From: Joakim Zhang @ 2018-10-23 5:31 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: kernel, Fabio Estevam, dl-linux-imx, robh+dt, linux-arm-kernel,
devicetree, linux-kernel, A.s. Dong, Joakim Zhang
From: Dong Aisheng <aisheng.dong@nxp.com>
Add stop-mode property which is required by stop mode wakeup
feature.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
arch/arm/boot/dts/imx6ul.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index 6dc0b569acdf..76486a42959c 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -407,6 +407,7 @@
clocks = <&clks IMX6UL_CLK_CAN1_IPG>,
<&clks IMX6UL_CLK_CAN1_SERIAL>;
clock-names = "ipg", "per";
+ stop-mode = <&gpr 0x10 1 0x10 17>;
status = "disabled";
};
@@ -417,6 +418,7 @@
clocks = <&clks IMX6UL_CLK_CAN2_IPG>,
<&clks IMX6UL_CLK_CAN2_SERIAL>;
clock-names = "ipg", "per";
+ stop-mode = <&gpr 0x10 2 0x10 18>;
status = "disabled";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V1 4/4] ARM: dts: imx7s: Add flexcan stop mode wakeup support
2018-10-23 5:30 [PATCH V1 0/4] ARM: dts: imx: Add flexcan stop mode wakeup Joakim Zhang
` (2 preceding siblings ...)
2018-10-23 5:31 ` [PATCH V1 3/4] ARM: dts: imx6ul: " Joakim Zhang
@ 2018-10-23 5:31 ` Joakim Zhang
3 siblings, 0 replies; 7+ messages in thread
From: Joakim Zhang @ 2018-10-23 5:31 UTC (permalink / raw)
To: shawnguo, s.hauer
Cc: kernel, Fabio Estevam, dl-linux-imx, robh+dt, linux-arm-kernel,
devicetree, linux-kernel, A.s. Dong, Joakim Zhang
From: Dong Aisheng <aisheng.dong@nxp.com>
Add stop-mode property which is required by stop mode wakeup
feature.
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
arch/arm/boot/dts/imx7s.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index a052198f6e96..382f1e1a92e3 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -877,6 +877,7 @@
clocks = <&clks IMX7D_CLK_DUMMY>,
<&clks IMX7D_CAN1_ROOT_CLK>;
clock-names = "ipg", "per";
+ stop-mode = <&gpr 0x10 1 0x10 17>;
status = "disabled";
};
@@ -887,6 +888,7 @@
clocks = <&clks IMX7D_CLK_DUMMY>,
<&clks IMX7D_CAN2_ROOT_CLK>;
clock-names = "ipg", "per";
+ stop-mode = <&gpr 0x10 2 0x10 18>;
status = "disabled";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread