From: Moritz Fischer <mdf@kernel.org>
To: Andreas Puhm <puhm@oregano.at>
Cc: "mdf@kernel.org" <mdf@kernel.org>,
"atull@kernel.org" <atull@kernel.org>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fpga: altera-cvp: Fix registration for CvP incapable devices
Date: Tue, 23 Oct 2018 10:26:39 +0100 [thread overview]
Message-ID: <20181023092639.GA4682@archbook> (raw)
In-Reply-To: <9b53d15391054a598ec3a32cee540798@SRV177.busymouse24.de>
Hi Andreas,
we're getting there :) It seems your mail setup is still a bit
funky though. Did you use git send-email / git format-patch?
On Tue, Oct 23, 2018 at 09:01:39AM +0000, Andreas Puhm wrote:
> From bfc602900b016f65bc2f183aa93702101a1fdc17 Mon Sep 17 00:00:00 2001
> From: Andreas Puhm <puhm@oregano.at>
> Date: Tue, 23 Oct 2018 10:24:10 +0200
> Subject: [PATCH] fpga: altera-cvp: Fix registration for CvP incapable devices
>
> The probe function needs to verify the CvP enable bit in order to properly determine if FPGA Manager functionality can be safely enabled.
>
> Fixes 34d1dc17ce978ae76e676d401b48fe9d004aa948 ("fpga manager: Add Altera CvP driver")
According to [1] this should be the first 12 characters of the SHA-1.
>
> Signed-off-by: Andreas Puhm <puhm@oregano.at>
> ---
> drivers/fpga/altera-cvp.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
> index 7fa793672a7a..ece344a56075 100644
> --- a/drivers/fpga/altera-cvp.c
> +++ b/drivers/fpga/altera-cvp.c
> @@ -403,6 +403,7 @@ static int altera_cvp_probe(struct pci_dev *pdev,
> struct altera_cvp_conf *conf;
> struct fpga_manager *mgr;
> u16 cmd, val;
> + u32 regval;
> int ret;
>
> /*
> @@ -416,6 +417,14 @@ static int altera_cvp_probe(struct pci_dev *pdev,
> return -ENODEV;
> }
>
> + pci_read_config_dword(pdev, VSE_CVP_STATUS, ®val);
> + if (!(regval & VSE_CVP_STATUS_CVP_EN)) {
> + dev_err(&pdev->dev,
> + "CVP is disabled for this device: CVP_STATUS Reg 0x%x\n",
> + regval);
> + return -ENODEV;
> + }
> +
> conf = devm_kzalloc(&pdev->dev, sizeof(*conf), GFP_KERNEL);
> if (!conf)
> return -ENOMEM;
> --
> 2.18.0.windows.1
>
It looks like you used Windows / Outlook or something. Please don't send
patches as attachment.
There's tutorials out there to set up git send-email with GMail for
example, if your current provider makes using git send-email hard.
[1] https://www.kernel.org/doc/html/v4.19/process/submitting-patches.html
Thanks,
Moritz
next prev parent reply other threads:[~2018-10-23 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 9:01 [PATCH] fpga: altera-cvp: Fix registration for CvP incapable devices Andreas Puhm
2018-10-23 9:26 ` Moritz Fischer [this message]
2018-10-23 14:53 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023092639.GA4682@archbook \
--to=mdf@kernel.org \
--cc=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puhm@oregano.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).