From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB8BC46475 for ; Tue, 23 Oct 2018 13:00:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7851520671 for ; Tue, 23 Oct 2018 13:00:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="u0BHRQIy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7851520671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727796AbeJWVXf (ORCPT ); Tue, 23 Oct 2018 17:23:35 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44818 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726277AbeJWVXf (ORCPT ); Tue, 23 Oct 2018 17:23:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QziV/CBCPYyfRcIL1PSQsrTW0Z/irr4rMFr39XgIheA=; b=u0BHRQIy56IvHJSEX3I5xmQUs hQfjEfj+78cHlQyak/h5xmgfrX+zXOueI5YtmRuiklt8T4QL8wrPaTINQV4G/YD8B9mtl8uW4rPYx Gc94+41GugqARkTJwEnoj3EqQRoFhJ5HIHmVYrfH1gclvoWy14ZerSpbbZF7nuTR1f5DE+5o5TCyF qXRd4+1VtuayCdNmScVQky+tcrtXFbrA0Sdif2biOv8/LHt8p6kMRSWmMhcZmRo0fP13Az6qVoBIW YRpjpq5RTBBtaUmJy+5+XK+hbKepGe0kWd4OetYUC9KjbaMYZTGyasmM3ZpTX7WeW4oij+Pl1HYsB ZKlWaXogA==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gEwHQ-0004JQ-Oz; Tue, 23 Oct 2018 12:59:28 +0000 Date: Tue, 23 Oct 2018 05:59:28 -0700 From: Matthew Wilcox To: Souptick Joarder Cc: Miguel Ojeda , Russell King - ARM Linux , robin@protonic.nl, stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, Heiko Stuebner , airlied@linux.ie, robin.murphy@arm.com, iamjoonsoo.kim@lge.com, Andrew Morton , Marek Szyprowski , Kees Cook , treding@nvidia.com, Michal Hocko , Dan Williams , "Kirill A. Shutemov" , Mark Rutland , aryabinin@virtuozzo.com, Dmitry Vyukov , Kate Stewart , tchibo@google.com, riel@redhat.com, Minchan Kim , Peter Zijlstra , "Huang, Ying" , ak@linux.intel.com, rppt@linux.vnet.ibm.com, linux@dominikbrodowski.net, Arnd Bergmann , cpandya@codeaurora.org, hannes@cmpxchg.org, Joe Perches , mcgrof@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Linux-MM Subject: Re: [PATCH v2] mm: Introduce new function vm_insert_kmem_page Message-ID: <20181023125928.GC20085@bombadil.infradead.org> References: <20181023122435.GB20085@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 23, 2018 at 06:03:42PM +0530, Souptick Joarder wrote: > On Tue, Oct 23, 2018 at 5:54 PM Matthew Wilcox wrote: > > On Tue, Oct 23, 2018 at 05:44:32PM +0530, Souptick Joarder wrote: > > > Instruction from Matthew Wilcox who is supervising the entire vm_fault_t > > > migration work :-) > > > > Hang on. That was for the initial vm_fault_t conversion in which each > > step was clearly an improvement. What you're looking at now is far > > from that. > > Ok. But my understanding was, the approach of vm_insert_range comes > into discussion as part of converting vm_insert_page into vmf_insert_page > which is still part of original vm_fault_t conversion discussion. No ? No. The initial part (converting all page fault methods to vm_fault_t) is done. What remains undone (looking at akpm's tree) is changing the typedef of vm_fault_t from int to unsigned int. That will prevent new page fault handlers with the wrong type from being added. I don't necessarily want to get rid of vm_insert_page(). Maybe it will make sense to do that, and maybe not. What I do want to see is thought, and not "Matthew told me to do it", when I didn't.