archive mirror
 help / color / mirror / Atom feed
From: Anatolij Gustschin <>
To: Andreas Puhm <>
Cc: Moritz Fischer <>, Alan Tull <>,
	"" <>,
	"" <>
Subject: Re: [PATCH] fpga: altera_cvp: restrict registration to CvP enabled devices
Date: Tue, 23 Oct 2018 18:26:49 +0200	[thread overview]
Message-ID: <20181023182649.047f1f93@crub> (raw)
In-Reply-To: <>

Hi Andreas,

On Mon, 22 Oct 2018 13:15:34 +0000
Andreas Puhm wrote:
>Full description:
>The altera_cvp probe function only checks, 
>if the Altera/Intel PCI device configuration space contains a vendor
>specific entry (VSEC Capability Header 0x000b) at offset 0x200.
> But the probe function does not verify, if the PCI device (and further
>the FPGA), for which it has been called, actually supports the Configure-
>via-Protocol feature.
>The PCI device (FPGA) can explicitly disable the Configur-via-Protocol
>(CvP) feature by setting the CVP_EN bit, index 20 of CVP_STATUS register,
>to '0'.
>As the altera_cvp probe function does not check this it registers the
>device in any way.

The CvP docs says that on some FPGAs (e.g. Arria 10) the assertion of CVP
status can take up to 500ms. However it is not clear whether this delay
might be required after peripheral image configuration and after PCIe
link activation. The diagram describing configuration sequence suggests
that CVP_EN should be polled until it is asserted. I can imaging the
situation that this bit is still not asserted when the device is being
probed. Maybe we should better defer device probing if CVP_EN bit is
cleared? When deferred probing fails again and sufficient period for
CVP_EN bit assertion elapsed, then stop deferred probing and return



  parent reply	other threads:[~2018-10-23 16:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-22 13:15 Andreas Puhm
2018-10-22 13:34 ` Eric Schwarz
2018-10-22 14:04 ` Moritz Fischer
2018-10-23 16:26 ` Anatolij Gustschin [this message]
2018-10-23 18:46   ` AW: " Andreas Puhm
2018-10-24  9:51     ` Moritz Fischer
2018-10-24 23:00       ` matthew.gerlach
2018-10-25  8:44         ` AW: " Andreas Puhm
2018-10-28 17:35           ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181023182649.047f1f93@crub \ \ \ \ \ \ \
    --subject='Re: [PATCH] fpga: altera_cvp: restrict registration to CvP enabled devices' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).